From cadb2e55d3a751b4eb0e7c5b34ed037af43a164c Mon Sep 17 00:00:00 2001
From: Aaron Conole <aconole@redhat.com>
Date: Wed, 25 Aug 2021 10:19:16 -0400
Subject: [PATCH 1/8] vdp22: convert command parsing to null term
There is a theoretical buffer escape here.
closes https://github.com/intel/openlldp/issues/74
Signed-off-by: Aaron Conole <aconole@redhat.com>
---
qbg/vdp22_cmds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qbg/vdp22_cmds.c b/qbg/vdp22_cmds.c
index a8025ee..0ded0f1 100644
--- a/qbg/vdp22_cmds.c
+++ b/qbg/vdp22_cmds.c
@@ -577,7 +577,7 @@ static int get_arg_vsi(struct cmd *cmd, char *arg, char *argvalue,
memset(&vsi, 0, sizeof(vsi));
memset(vsi_str, 0, sizeof(vsi_str));
vsi.request = cmd->tlvid;
- strncpy(vsi.ifname, cmd->ifname, sizeof(vsi.ifname));
+ STRNCPY_TERMINATED(vsi.ifname, cmd->ifname, sizeof(vsi.ifname));
good_cmd = cmd_failed;
if ((cmd->ops & op_config) && (cmd->ops & op_arg)) {
memset(&mac, 0, sizeof(mac));
--
2.31.1