Blame SOURCES/0001-vdp22-convert-command-parsing-to-null-term.patch
|
 |
449e93 |
From cadb2e55d3a751b4eb0e7c5b34ed037af43a164c Mon Sep 17 00:00:00 2001
|
|
|
449e93 |
From: Aaron Conole <aconole@redhat.com>
|
|
|
449e93 |
Date: Wed, 25 Aug 2021 10:19:16 -0400
|
|
|
449e93 |
Subject: [PATCH 1/8] vdp22: convert command parsing to null term
|
|
|
449e93 |
|
|
|
449e93 |
There is a theoretical buffer escape here.
|
|
|
449e93 |
|
|
|
449e93 |
closes https://github.com/intel/openlldp/issues/74
|
|
|
449e93 |
Signed-off-by: Aaron Conole <aconole@redhat.com>
|
|
|
449e93 |
---
|
|
|
449e93 |
qbg/vdp22_cmds.c | 2 +-
|
|
|
449e93 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
449e93 |
|
|
|
449e93 |
diff --git a/qbg/vdp22_cmds.c b/qbg/vdp22_cmds.c
|
|
|
449e93 |
index a8025ee..0ded0f1 100644
|
|
|
449e93 |
--- a/qbg/vdp22_cmds.c
|
|
|
449e93 |
+++ b/qbg/vdp22_cmds.c
|
|
|
449e93 |
@@ -577,7 +577,7 @@ static int get_arg_vsi(struct cmd *cmd, char *arg, char *argvalue,
|
|
|
449e93 |
memset(&vsi, 0, sizeof(vsi));
|
|
|
449e93 |
memset(vsi_str, 0, sizeof(vsi_str));
|
|
|
449e93 |
vsi.request = cmd->tlvid;
|
|
|
449e93 |
- strncpy(vsi.ifname, cmd->ifname, sizeof(vsi.ifname));
|
|
|
449e93 |
+ STRNCPY_TERMINATED(vsi.ifname, cmd->ifname, sizeof(vsi.ifname));
|
|
|
449e93 |
good_cmd = cmd_failed;
|
|
|
449e93 |
if ((cmd->ops & op_config) && (cmd->ops & op_arg)) {
|
|
|
449e93 |
memset(&mac, 0, sizeof(mac));
|
|
|
449e93 |
--
|
|
|
449e93 |
2.31.1
|
|
|
449e93 |
|