From 4d631df78d550276854ec99fbcbbfc0414053c60 Mon Sep 17 00:00:00 2001
From: Ravishankar N <ravishankar@redhat.com>
Date: Sun, 19 Mar 2017 22:42:33 +0530
Subject: [PATCH 484/486] afr: do not mention split-brain in log message in
read_txn
Backport of : https://review.gluster.org/16879
I am seeing a lot of messages in qe/customer logs where read_txn
complains that file is possibly in split-brain because of no readable
subvol being found, does inode refresh and then there is no split-brain
message post the inode refresh. This means that a lookup was not issued
on the indoe to populate 'readable' or it can mean one brick is source
for data and the other for metadata, making readable to be zero (because
readable=intersection of (data,metadata readable) since commit
7a1c1e290470149696.
Since we anyway log actual split-brains post inode-refresh, move this
message to DEBUG log level.
Change-Id: I8ee3b0558cfce8c3cc921dd9e3c0340f99bf9f8d
BUG: 1454689
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: https://code.engineering.redhat.com/gerrit/108105
Reviewed-by: Karthik Subrahmanya <ksubrahm@redhat.com>
---
xlators/cluster/afr/src/afr-read-txn.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/xlators/cluster/afr/src/afr-read-txn.c b/xlators/cluster/afr/src/afr-read-txn.c
index ecc9194..86472f1 100644
--- a/xlators/cluster/afr/src/afr-read-txn.c
+++ b/xlators/cluster/afr/src/afr-read-txn.c
@@ -223,9 +223,8 @@ afr_read_txn (call_frame_t *frame, xlator_t *this, inode_t *inode,
local->readable, NULL);
if (read_subvol < 0 || read_subvol > priv->child_count) {
- gf_msg (this->name, GF_LOG_WARNING, 0, AFR_MSG_SPLIT_BRAIN,
- "Unreadable subvolume %d found with event generation "
- "%d for gfid %s. (Possible split-brain)",
+ gf_msg_debug (this->name, 0, "Unreadable subvolume %d found "
+ "with event generation %d for gfid %s.",
read_subvol, event_generation, uuid_utoa(inode->gfid));
goto refresh;
}
--
1.8.3.1