|
 |
21ab4e |
From 4d631df78d550276854ec99fbcbbfc0414053c60 Mon Sep 17 00:00:00 2001
|
|
|
21ab4e |
From: Ravishankar N <ravishankar@redhat.com>
|
|
|
21ab4e |
Date: Sun, 19 Mar 2017 22:42:33 +0530
|
|
|
21ab4e |
Subject: [PATCH 484/486] afr: do not mention split-brain in log message in
|
|
|
21ab4e |
read_txn
|
|
|
21ab4e |
|
|
|
21ab4e |
Backport of : https://review.gluster.org/16879
|
|
|
21ab4e |
|
|
|
21ab4e |
I am seeing a lot of messages in qe/customer logs where read_txn
|
|
|
21ab4e |
complains that file is possibly in split-brain because of no readable
|
|
|
21ab4e |
subvol being found, does inode refresh and then there is no split-brain
|
|
|
21ab4e |
message post the inode refresh. This means that a lookup was not issued
|
|
|
21ab4e |
on the indoe to populate 'readable' or it can mean one brick is source
|
|
|
21ab4e |
for data and the other for metadata, making readable to be zero (because
|
|
|
21ab4e |
readable=intersection of (data,metadata readable) since commit
|
|
|
21ab4e |
7a1c1e290470149696.
|
|
|
21ab4e |
|
|
|
21ab4e |
Since we anyway log actual split-brains post inode-refresh, move this
|
|
|
21ab4e |
message to DEBUG log level.
|
|
|
21ab4e |
|
|
|
21ab4e |
Change-Id: I8ee3b0558cfce8c3cc921dd9e3c0340f99bf9f8d
|
|
|
21ab4e |
BUG: 1454689
|
|
|
21ab4e |
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
|
|
|
21ab4e |
Reviewed-on: https://code.engineering.redhat.com/gerrit/108105
|
|
|
21ab4e |
Reviewed-by: Karthik Subrahmanya <ksubrahm@redhat.com>
|
|
|
21ab4e |
---
|
|
|
21ab4e |
xlators/cluster/afr/src/afr-read-txn.c | 5 ++---
|
|
|
21ab4e |
1 file changed, 2 insertions(+), 3 deletions(-)
|
|
|
21ab4e |
|
|
|
21ab4e |
diff --git a/xlators/cluster/afr/src/afr-read-txn.c b/xlators/cluster/afr/src/afr-read-txn.c
|
|
|
21ab4e |
index ecc9194..86472f1 100644
|
|
|
21ab4e |
--- a/xlators/cluster/afr/src/afr-read-txn.c
|
|
|
21ab4e |
+++ b/xlators/cluster/afr/src/afr-read-txn.c
|
|
|
21ab4e |
@@ -223,9 +223,8 @@ afr_read_txn (call_frame_t *frame, xlator_t *this, inode_t *inode,
|
|
|
21ab4e |
local->readable, NULL);
|
|
|
21ab4e |
|
|
|
21ab4e |
if (read_subvol < 0 || read_subvol > priv->child_count) {
|
|
|
21ab4e |
- gf_msg (this->name, GF_LOG_WARNING, 0, AFR_MSG_SPLIT_BRAIN,
|
|
|
21ab4e |
- "Unreadable subvolume %d found with event generation "
|
|
|
21ab4e |
- "%d for gfid %s. (Possible split-brain)",
|
|
|
21ab4e |
+ gf_msg_debug (this->name, 0, "Unreadable subvolume %d found "
|
|
|
21ab4e |
+ "with event generation %d for gfid %s.",
|
|
|
21ab4e |
read_subvol, event_generation, uuid_utoa(inode->gfid));
|
|
|
21ab4e |
goto refresh;
|
|
|
21ab4e |
}
|
|
|
21ab4e |
--
|
|
|
21ab4e |
1.8.3.1
|
|
|
21ab4e |
|