Blob Blame History Raw
From 086b3c45f1372c028ced16ce67f1e84dd6d67ed6 Mon Sep 17 00:00:00 2001
From: Poornima G <pgurusid@redhat.com>
Date: Fri, 4 Nov 2016 15:56:42 +0530
Subject: [PATCH 176/206] upcall: Fix a log level

Backport of http://review.gluster.org/15777

In upcall_cache_invalidation(), the gfid can be NULL in certain
valid test cases(eg: entry for ".." in readdirp), hence change
the log level from WARNING to DEBUG.

Change-Id: Ic90167a0e2076694e9131913114460df7b939b30
BUG: 1389422
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: http://review.gluster.org/15777
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Signed-off-by: Poornima G <pgurusid@redhat.com>
Reviewed-on: https://code.engineering.redhat.com/gerrit/90547
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
---
 xlators/features/upcall/src/upcall-internal.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/xlators/features/upcall/src/upcall-internal.c b/xlators/features/upcall/src/upcall-internal.c
index c7d7dab..43a6b20 100644
--- a/xlators/features/upcall/src/upcall-internal.c
+++ b/xlators/features/upcall/src/upcall-internal.c
@@ -566,8 +566,13 @@ upcall_cache_invalidate (call_frame_t *frame, xlator_t *this, client_t *client,
                 gf_uuid_copy (up_inode_ctx->gfid, stbuf->ia_gfid);
         }
 
-        GF_VALIDATE_OR_GOTO ("upcall_cache_invalidate",
-                             !(gf_uuid_is_null (up_inode_ctx->gfid)), out);
+        if (gf_uuid_is_null (up_inode_ctx->gfid)) {
+                gf_msg_debug (this->name, 0, "up_inode_ctx->gfid and "
+                              "stbuf->ia_gfid is NULL, fop:%s",
+                              gf_fop_list[frame->root->op]);
+                goto out;
+        }
+
         pthread_mutex_lock (&up_inode_ctx->client_list_lock);
         {
                 list_for_each_entry_safe (up_client_entry, tmp,
-- 
2.9.3