3604df
From 086b3c45f1372c028ced16ce67f1e84dd6d67ed6 Mon Sep 17 00:00:00 2001
3604df
From: Poornima G <pgurusid@redhat.com>
3604df
Date: Fri, 4 Nov 2016 15:56:42 +0530
3604df
Subject: [PATCH 176/206] upcall: Fix a log level
3604df
3604df
Backport of http://review.gluster.org/15777
3604df
3604df
In upcall_cache_invalidation(), the gfid can be NULL in certain
3604df
valid test cases(eg: entry for ".." in readdirp), hence change
3604df
the log level from WARNING to DEBUG.
3604df
3604df
Change-Id: Ic90167a0e2076694e9131913114460df7b939b30
3604df
BUG: 1389422
3604df
Signed-off-by: Poornima G <pgurusid@redhat.com>
3604df
Reviewed-on: http://review.gluster.org/15777
3604df
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
3604df
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
3604df
Smoke: Gluster Build System <jenkins@build.gluster.org>
3604df
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
3604df
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
3604df
Signed-off-by: Poornima G <pgurusid@redhat.com>
3604df
Reviewed-on: https://code.engineering.redhat.com/gerrit/90547
3604df
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
3604df
---
3604df
 xlators/features/upcall/src/upcall-internal.c | 9 +++++++--
3604df
 1 file changed, 7 insertions(+), 2 deletions(-)
3604df
3604df
diff --git a/xlators/features/upcall/src/upcall-internal.c b/xlators/features/upcall/src/upcall-internal.c
3604df
index c7d7dab..43a6b20 100644
3604df
--- a/xlators/features/upcall/src/upcall-internal.c
3604df
+++ b/xlators/features/upcall/src/upcall-internal.c
3604df
@@ -566,8 +566,13 @@ upcall_cache_invalidate (call_frame_t *frame, xlator_t *this, client_t *client,
3604df
                 gf_uuid_copy (up_inode_ctx->gfid, stbuf->ia_gfid);
3604df
         }
3604df
 
3604df
-        GF_VALIDATE_OR_GOTO ("upcall_cache_invalidate",
3604df
-                             !(gf_uuid_is_null (up_inode_ctx->gfid)), out);
3604df
+        if (gf_uuid_is_null (up_inode_ctx->gfid)) {
3604df
+                gf_msg_debug (this->name, 0, "up_inode_ctx->gfid and "
3604df
+                              "stbuf->ia_gfid is NULL, fop:%s",
3604df
+                              gf_fop_list[frame->root->op]);
3604df
+                goto out;
3604df
+        }
3604df
+
3604df
         pthread_mutex_lock (&up_inode_ctx->client_list_lock);
3604df
         {
3604df
                 list_for_each_entry_safe (up_client_entry, tmp,
3604df
-- 
3604df
2.9.3
3604df