From bc712aca20f55565e259d666284947d645348f7e Mon Sep 17 00:00:00 2001
From: Jonathon Jongsma <jjongsma@redhat.com>
Date: Wed, 20 Aug 2014 14:19:31 -0500
Subject: [PATCH] App: keep hash table of displays
This is part of a re-factoring that will de-couple the client window
from the remote display id.
(cherry picked from commit 573c1cfc9118b730f2ff5aa6a7d45529f2978fbf)
Conflicts:
src/virt-viewer-app.c
---
src/virt-viewer-app.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
index b05e966..0b86b9b 100644
--- a/src/virt-viewer-app.c
+++ b/src/virt-viewer-app.c
@@ -109,6 +109,7 @@ struct _VirtViewerAppPrivate {
VirtViewerWindow *main_window;
GtkWidget *main_notebook;
GHashTable *windows;
+ GHashTable *displays;
GHashTable *initial_display_map;
gchar *clipboard;
@@ -919,6 +920,10 @@ virt_viewer_app_display_added(VirtViewerSession *session G_GNUC_UNUSED,
gint nth;
g_object_get(display, "nth-display", &nth, NULL);
+
+ g_debug("Insert display %d %p", nth, display);
+ g_hash_table_insert(self->priv->displays, GINT_TO_POINTER(nth), g_object_ref(display));
+
if (nth == 0) {
window = priv->main_window;
} else {
@@ -952,6 +957,7 @@ virt_viewer_app_display_removed(VirtViewerSession *session G_GNUC_UNUSED,
gtk_widget_hide(GTK_WIDGET(display));
g_object_get(display, "nth-display", &nth, NULL);
+ g_hash_table_remove(self->priv->displays, GINT_TO_POINTER(nth));
win = virt_viewer_app_get_nth_window(self, nth);
if (!win)
return;
@@ -1622,6 +1628,15 @@ virt_viewer_app_dispose (GObject *object)
g_hash_table_unref(tmp);
}
+ if (priv->displays) {
+ GHashTable *tmp = priv->displays;
+ /* null-ify before unrefing, because we need
+ * to prevent callbacks using priv->displays
+ * while it is being disposed of. */
+ priv->displays = NULL;
+ g_hash_table_unref(tmp);
+ }
+
g_clear_object(&priv->session);
g_free(priv->title);
priv->title = NULL;
@@ -1682,6 +1697,7 @@ virt_viewer_app_init (VirtViewerApp *self)
virt_viewer_app_set_debug(opt_debug);
self->priv = GET_PRIVATE(self);
+ self->priv->displays = g_hash_table_new_full(g_direct_hash, g_direct_equal, NULL, g_object_unref);
self->priv->windows = g_hash_table_new_full(g_int_hash, g_int_equal, g_free, g_object_unref);
self->priv->config = g_key_file_new();
self->priv->config_file = g_build_filename(g_get_user_config_dir(),