Blob Blame History Raw
From 5cc0b67726652b56815cf3459737260e3e3479ba Mon Sep 17 00:00:00 2001
From: Cole Robinson <crobinso@redhat.com>
Date: Sun, 21 Sep 2014 15:26:03 -0400
Subject: [PATCH 1/2] tests: Ensure osdict.py aliases is never extended

(cherry picked from commit b3fa8bb650c1ecfbb13ee6235fc7a306a0f0b318)
---
 tests/misc.py      | 9 +++++++++
 virtinst/osdict.py | 2 ++
 2 files changed, 11 insertions(+)

diff --git a/tests/misc.py b/tests/misc.py
index ca91595..b532cdf 100644
--- a/tests/misc.py
+++ b/tests/misc.py
@@ -112,3 +112,12 @@ class TestMisc(unittest.TestCase):
             raise AssertionError("The following files require a gtk version "
                 "higher than our target of gtk-3.8:\n" +
                 "\n".join([("%s version=%s" % tup) for tup in failures]))
+
+    def test_libosinfo_aliases_ro(self):
+        from virtinst import osdict
+        aliases = getattr(osdict, "_aliases")
+
+        if len(aliases) != 36:
+            raise AssertionError(_("osdict._aliases changed size. It "
+                "should never be extended, since it is only for back "
+                "compat with pre-libosinfo osdict."))
diff --git a/virtinst/osdict.py b/virtinst/osdict.py
index f792012..4659019 100644
--- a/virtinst/osdict.py
+++ b/virtinst/osdict.py
@@ -25,6 +25,8 @@ from datetime import datetime
 from gi.repository import Libosinfo as libosinfo
 from inspect import isfunction
 
+# This is only for back compatibility with pre-libosinfo support.
+# This should never change.
 _aliases = {
     "altlinux" : "altlinux1.0",
     "debianetch" : "debian4",
-- 
1.9.3