Blob Blame History Raw
From 0cc2b81575b0ce04edaa4a94db91f1cc37292ea6 Mon Sep 17 00:00:00 2001
Message-Id: <0cc2b81575b0ce04edaa4a94db91f1cc37292ea6@dist-git>
From: Pavel Hrdina <phrdina@redhat.com>
Date: Thu, 3 Oct 2019 10:50:34 +0200
Subject: [PATCH] video: Prefer "bochs" when it's supported.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Fabiano FidĂȘncio <fidencio@redhat.com>

Preferring "bochs" display device is the way to go when dealing with a
Linux guest using UEFI and that's quite well described here:
https://www.kraxel.org/blog/2019/09/display-devices-in-qemu/

https://bugzilla.redhat.com/show_bug.cgi?id=1753644

Signed-off-by: Fabiano FidĂȘncio <fidencio@redhat.com>
(cherry picked from commit 8f4c53ea960459516794ba533060a176cc26f121)

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1753644

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
---
 virtinst/devices/video.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/virtinst/devices/video.py b/virtinst/devices/video.py
index 3ebc561f..fcca91b6 100644
--- a/virtinst/devices/video.py
+++ b/virtinst/devices/video.py
@@ -39,6 +39,9 @@ class DeviceVideo(Device):
             if guest.has_gl():
                 return "virtio"
             return "qxl"
+        if (guest.is_uefi() and
+            guest.lookup_domcaps().supports_video_bochs()):
+            return "bochs"
         if guest.conn.is_qemu():
             return "qxl"
         return "vga"
-- 
2.23.0