From acb3b3ddc082880eaaa1d7773296ad9abd756f23 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= <zbyszek@in.waw.pl>
Date: Tue, 30 Sep 2014 07:44:04 -0400
Subject: [PATCH] shared: util - use nicer idiom to silence Coverity
Change the other spot too.
---
src/shared/util.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/src/shared/util.c b/src/shared/util.c
index ebacee55b1..bbd9bd11d6 100644
--- a/src/shared/util.c
+++ b/src/shared/util.c
@@ -3306,13 +3306,8 @@ unsigned lines(void) {
l = 0;
e = getenv("LINES");
- if (e) {
- int r;
-
- r = safe_atou(e, &l);
- if (r < 0) {}
- /* do nothing, we fall back to l = 0 */
- }
+ if (e)
+ (void) safe_atou(e, &l);
if (l <= 0)
l = fd_lines(STDOUT_FILENO);