From 4e1111d869c8980f81a17b58844c48f1a342d774 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn@redhat.com>
Date: Thu, 4 Aug 2016 08:50:50 +0200
Subject: [PATCH 68/74] SDAP: sysdb_search_users does not set users_count for
 failures
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

==32577== Conditional jump or move depends on uninitialised value(s)
==32577==    at 0x140DCE10: sdap_process_missing_member_2307 (sdap_async_groups.c:1556)
==32577==    by 0x140DCE10: sdap_process_group_members_2307 (sdap_async_groups.c:1625)
==32577==    by 0x140DCE10: sdap_process_group_send (sdap_async_groups.c:1298)
==32577==    by 0x140DCE10: sdap_get_groups_process (sdap_async_groups.c:2130)
==32577==    by 0x140CFDA8: generic_ext_search_handler.isra.3 (sdap_async.c:1688)
==32577==    by 0x140D2416: sdap_get_generic_op_finished (sdap_async.c:1578)
==32577==    by 0x140D0DFC: sdap_process_message (sdap_async.c:353)
==32577==    by 0x140D0DFC: sdap_process_result (sdap_async.c:197)
==32577==    by 0x8BF1B4E: tevent_common_loop_timer_delay (tevent_timed.c:341)
==32577==    by 0x8BF2B59: epoll_event_loop_once (tevent_epoll.c:911)
==32577==    by 0x8BF1256: std_event_loop_once (tevent_standard.c:114)
==32577==    by 0x8BED40C: _tevent_loop_once (tevent.c:533)
==32577==    by 0x8BED5AA: tevent_common_loop_wait (tevent.c:637)
==32577==    by 0x8BF11F6: std_event_loop_wait (tevent_standard.c:140)
==32577==    by 0x529DD02: server_loop (server.c:702)
==32577==    by 0x110951: main (data_provider_be.c:587)

Resolves:
https://fedorahosted.org/sssd/ticket/3121

Reviewed-by: Pavel Březina <pbrezina@redhat.com>
---
 src/providers/ldap/sdap_async_groups.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/providers/ldap/sdap_async_groups.c b/src/providers/ldap/sdap_async_groups.c
index f19b68b8c403734f88b51a411ba0d009977d3491..72760b75acae4cb6ce15c72f16dae8e859d89847 100644
--- a/src/providers/ldap/sdap_async_groups.c
+++ b/src/providers/ldap/sdap_async_groups.c
@@ -1553,7 +1553,7 @@ sdap_process_missing_member_2307(struct sdap_process_group_state *state,
         if (ret != EOK) {
             DEBUG(SSSDBG_OP_FAILURE, "Could not add group member %s\n", username);
         }
-    } else if (ret == ENOENT || count == 0) {
+    } else if (ret == ENOENT) {
         /* The entry really does not exist, add a ghost */
         DEBUG(SSSDBG_TRACE_FUNC, "Adding a ghost entry\n");
         ret = sdap_add_group_member_2307(state->ghost_dns, member_name);
-- 
2.4.11