Blob Blame History Raw
From be9dc78fccc80bb5045c67b435b5c7e36ea8a296 Mon Sep 17 00:00:00 2001
From: Yasuo Honda <yasuo.honda@gmail.com>
Date: Thu, 11 Aug 2016 11:26:20 +0000
Subject: [PATCH] Creating a new Topic class instead of class_eval for the
 existing one since it affects another test
 `ReflectionTest#test_read_attribute_names`

Address #26099
---
 activerecord/test/cases/validations_test.rb | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/activerecord/test/cases/validations_test.rb b/activerecord/test/cases/validations_test.rb
index 76510cb..5d9aa99 100644
--- a/activerecord/test/cases/validations_test.rb
+++ b/activerecord/test/cases/validations_test.rb
@@ -156,17 +156,15 @@ def test_validators
   end
 
   def test_numericality_validation_with_mutation
-    Topic.class_eval do
+    klass = Class.new(Topic) do
       attribute :wibble, :string
       validates_numericality_of :wibble, only_integer: true
     end
 
-    topic = Topic.new(wibble: '123-4567')
+    topic = klass.new(wibble: "123-4567")
     topic.wibble.gsub!('-', '')
 
     assert topic.valid?
-  ensure
-    Topic.reset_column_information
   end
 
   def test_acceptance_validator_doesnt_require_db_connection