Blob Blame History Raw
From f7d96acb6d990b4d68116214e3ab351def63b1d7 Mon Sep 17 00:00:00 2001
From: Daniel Bevenius <daniel.bevenius@gmail.com>
Date: Fri, 18 May 2018 09:58:37 +0200
Subject: [PATCH] http2: pass session to DEBUG_HTTP2SESSION2

When configure with --debug-http2 --debug-nghttp2 the following
compilation error is generated:

DEBUG_HTTP2SESSION2(this, "fatal error receiving data: %d", ret);
                          ^
../src/node_http2.cc:1690:27:
error: invalid use of 'this' outside of a non-static member function

1 errors generated.

OnStreamReadImpl is static and I think the intention was to pass in the
session variable here.

PR-URL: https://github.com/nodejs/node/pull/20815
Refs: https://github.com/nodejs/node/issues/20806
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
---
 src/node_http2.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/node_http2.cc b/src/node_http2.cc
index b3187858230..4aa9fceec18 100644
--- a/src/node_http2.cc
+++ b/src/node_http2.cc
@@ -1687,7 +1687,7 @@ void Http2Session::OnStreamReadImpl(ssize_t nread,
     // ssize_t to int. Cast here so that the < 0 check actually works on
     // Windows.
     if (static_cast<int>(ret) < 0) {
-      DEBUG_HTTP2SESSION2(this, "fatal error receiving data: %d", ret);
+      DEBUG_HTTP2SESSION2(session, "fatal error receiving data: %d", ret);
 
       Local<Value> argv[1] = {
         Integer::New(isolate, ret),