From 9f25aebffc4f6d4d9b7ccf3e1ba911b997fb9ab4 Mon Sep 17 00:00:00 2001
From: Honggang Li <honli@redhat.com>
Date: Sun, 15 Nov 2020 17:53:47 +0800
Subject: [PATCH] qedr: fix USE_AFTER_FREE issue

[ Upstream commit 56137398dbd58f876cb6238da9babb9500ac38b4 ]

Issue was detected by Coverity.

Error: USE_AFTER_FREE (CWE-416): [#def10]
rdma-core-33.0/providers/qedr/qelr_verbs.c:2678: freed_arg: "free" frees "srq".
rdma-core-33.0/providers/qedr/qelr_verbs.c:2680: pass_freed_arg: Passing freed pointer "srq" as an argument to "fprintf".
|# 2678|   	free(srq);
|# 2679|   err0:
|# 2680|-> 	DP_ERR(cxt->dbg_fp,
|# 2681|   	       "create srq: failed to create %p. rc=%d\n", srq, rc);
|# 2682|   	return NULL;

Fixes: cae4a99ae679 ("libqedr: add support for XRC-SRQ's.")
Signed-off-by: Honggang Li <honli@redhat.com>
Signed-off-by: Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
---
 providers/qedr/qelr_verbs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/providers/qedr/qelr_verbs.c b/providers/qedr/qelr_verbs.c
index 4e77a1976a91..e75d508f100b 100644
--- a/providers/qedr/qelr_verbs.c
+++ b/providers/qedr/qelr_verbs.c
@@ -2678,7 +2678,7 @@ err1:
 	free(srq);
 err0:
 	DP_ERR(cxt->dbg_fp,
-	       "create srq: failed to create %p. rc=%d\n", srq, rc);
+	       "create srq: failed to create. rc=%d\n", rc);
 	return NULL;
 }
 
-- 
2.25.4