Blob Blame History Raw
From 2fdce8ec0e631b759bb03a35457b17060605d887 Mon Sep 17 00:00:00 2001
From: Ilya Maximets <i.maximets@ovn.org>
Date: Tue, 12 May 2020 12:46:18 +0200
Subject: [PATCH 2/2] ovn-northd: Fix memory leak in case of duplicate logical
 router port.

'lrp_networks' must be destroyed on error path.

Fixes: 8e83e561879a ("ovn: Support multiple addresses on a single logical router port.")
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Signed-off-by: Numan Siddique <numans@ovn.org>
---
 northd/ovn-northd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
index c1cdb2280..a41e3d46e 100644
--- a/northd/ovn-northd.c
+++ b/northd/ovn-northd.c
@@ -2125,6 +2125,7 @@ join_logical_ports(struct northd_context *ctx,
                             = VLOG_RATE_LIMIT_INIT(5, 1);
                         VLOG_WARN_RL(&rl, "duplicate logical router port %s",
                                      nbrp->name);
+                        destroy_lport_addresses(&lrp_networks);
                         continue;
                     }
                     ovn_port_set_nb(op, NULL, nbrp);
-- 
2.26.2