Blob Blame History Raw
From 5f512f6e9e72c10a4ad32a08b1bab095014c9057 Mon Sep 17 00:00:00 2001
From: Vratislav Podzimek <vpodzime@redhat.com>
Date: Thu, 26 May 2016 10:04:17 +0200
Subject: [PATCH 11/13] Make the changes overview scrollable and smaller

There might possibly be many changes which would cause the view to overflow the
screen or push some elements outside of the screen resulting in permanent damage
to Anaconda's UI. Let's prevent this from happening by making the view
scrollable. The 'automatic' policy should make sure there are no scrollbars
unless needed. Disabling the horizontal expand makes sure that the changes view
doesn't take too much space from the screen when not needed.

Related: rhbz#1263582
---
 org_fedora_oscap/gui/spokes/oscap.glade | 46 +++++++++++++++++++--------------
 1 file changed, 26 insertions(+), 20 deletions(-)

diff --git a/org_fedora_oscap/gui/spokes/oscap.glade b/org_fedora_oscap/gui/spokes/oscap.glade
index 3737eba..5ce20b0 100644
--- a/org_fedora_oscap/gui/spokes/oscap.glade
+++ b/org_fedora_oscap/gui/spokes/oscap.glade
@@ -351,32 +351,38 @@
                           </packing>
                         </child>
                         <child>
-                          <object class="GtkTreeView" id="changesView">
+                          <object class="GtkScrolledWindow" id="changesWindow">
                             <property name="visible">True</property>
                             <property name="can_focus">True</property>
-                            <property name="hexpand">True</property>
-                            <property name="vexpand">True</property>
-                            <property name="model">changesStore</property>
-                            <property name="headers_visible">False</property>
-                            <property name="headers_clickable">False</property>
-                            <property name="search_column">0</property>
-                            <child internal-child="selection">
-                              <object class="GtkTreeSelection" id="treeview-selection3"/>
-                            </child>
+                            <property name="shadow_type">in</property>
                             <child>
-                              <object class="GtkTreeViewColumn" id="messageTypeColumn">
+                              <object class="GtkTreeView" id="changesView">
+                                <property name="visible">True</property>
+                                <property name="can_focus">True</property>
+                                <property name="hexpand">True</property>
+                                <property name="model">changesStore</property>
+                                <property name="headers_visible">False</property>
+                                <property name="headers_clickable">False</property>
+                                <property name="search_column">0</property>
+                                <child internal-child="selection">
+                                  <object class="GtkTreeSelection" id="treeview-selection"/>
+                                </child>
                                 <child>
-                                  <object class="GtkCellRendererPixbuf" id="messageTypeRenderer"/>
+                                  <object class="GtkTreeViewColumn" id="messageTypeColumn">
+                                    <child>
+                                      <object class="GtkCellRendererPixbuf" id="messageTypeRenderer"/>
+                                    </child>
+                                  </object>
                                 </child>
-                              </object>
-                            </child>
-                            <child>
-                              <object class="GtkTreeViewColumn" id="messageColumn">
                                 <child>
-                                  <object class="GtkCellRendererText" id="cellrenderertext2"/>
-                                  <attributes>
-                                    <attribute name="text">1</attribute>
-                                  </attributes>
+                                  <object class="GtkTreeViewColumn" id="messageColumn">
+                                    <child>
+                                      <object class="GtkCellRendererText" id="cellrenderertext2"/>
+                                      <attributes>
+                                        <attribute name="text">1</attribute>
+                                      </attributes>
+                                    </child>
+                                  </object>
                                 </child>
                               </object>
                             </child>
-- 
2.5.5