Blob Blame History Raw
From 4a7e5169935c8850fddcea8da79639ded907c549 Mon Sep 17 00:00:00 2001
From: "Richard W.M. Jones" <rjones@redhat.com>
Date: Sat, 14 May 2022 14:00:16 +0100
Subject: [PATCH] curl: Don't document curl plugin + readahead filter

nbdkit readahead filter does not support plugins which do not use the
parallel thread model.

Fixes: commit 2ff548d66ad3eae87868402ec5b3319edd12090f
(cherry picked from commit 92fbb76d11b9f17c527debd803aa2505f3642783)
---
 docs/nbdkit-captive.pod             | 7 -------
 plugins/curl/nbdkit-curl-plugin.pod | 1 -
 2 files changed, 8 deletions(-)

diff --git a/docs/nbdkit-captive.pod b/docs/nbdkit-captive.pod
index eafe36d8..d41a824d 100644
--- a/docs/nbdkit-captive.pod
+++ b/docs/nbdkit-captive.pod
@@ -110,13 +110,6 @@ an embedded disk image.  To copy it out:
 
  nbdkit -U - example1 --run 'qemu-img convert $nbd disk.img'
 
-If plugin requests have a high overhead (for example making HTTP
-requests to a remote server), adding L<nbdkit-readahead-filter(1)> may
-help performance:
-
- nbdkit -U - --filter=readahead curl https://example.com/disk.img \
-        --run 'qemu-img convert $nbd disk.img'
-
 If the source suffers from temporary network failures
 L<nbdkit-retry-filter(1)> or L<nbdkit-retry-request-filter(1)> may
 help.
diff --git a/plugins/curl/nbdkit-curl-plugin.pod b/plugins/curl/nbdkit-curl-plugin.pod
index 54fce66c..fc422ca2 100644
--- a/plugins/curl/nbdkit-curl-plugin.pod
+++ b/plugins/curl/nbdkit-curl-plugin.pod
@@ -509,7 +509,6 @@ L<CURLOPT_VERBOSE(3)>,
 L<nbdkit(1)>,
 L<nbdkit-extentlist-filter(1)>,
 L<nbdkit-file-plugin(1)>,
-L<nbdkit-readahead-filter(1)>,
 L<nbdkit-retry-filter(1)>,
 L<nbdkit-retry-request-filter(1)>,
 L<nbdkit-ssh-plugin(1)>,
-- 
2.31.1