Blob Blame History Raw
From 7423bf0192310509ff963d2b67c85409a501d4e3 Mon Sep 17 00:00:00 2001
From: Alexander Bokovoy <abokovoy@redhat.com>
Date: Wed, 24 Feb 2021 20:55:41 +0200
Subject: [PATCH] ipa-kdb: mark test functions as static

No need to define missing prototypes to single use test functions.

Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
Reviewed-By: Robbie Harwood <rharwood@redhat.com>
Reviewed-By: Rob Crittenden <rcritten@redhat.com>
Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
---
 daemons/ipa-kdb/tests/ipa_kdb_tests.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/daemons/ipa-kdb/tests/ipa_kdb_tests.c b/daemons/ipa-kdb/tests/ipa_kdb_tests.c
index 7f1ae7f66e233d779433eff4e5f32fe7fafc3f02..1f94afe486fd09c497ee8b8aa16880d1840603d0 100644
--- a/daemons/ipa-kdb/tests/ipa_kdb_tests.c
+++ b/daemons/ipa-kdb/tests/ipa_kdb_tests.c
@@ -164,7 +164,7 @@ extern krb5_error_code filter_logon_info(krb5_context context,
                                   krb5_data realm,
                                   struct PAC_LOGON_INFO_CTR *info);
 
-void test_filter_logon_info(void **state)
+static void test_filter_logon_info(void **state)
 {
     krb5_error_code kerr;
     krb5_data realm = {KV5M_DATA, REALM_LEN, REALM};
@@ -299,10 +299,7 @@ void test_filter_logon_info(void **state)
 
 }
 
-extern void get_authz_data_types(krb5_context context, krb5_db_entry *entry,
-                                 bool *with_pac, bool *with_pad);
-
-void test_get_authz_data_types(void **state)
+static void test_get_authz_data_types(void **state)
 {
     bool with_pac;
     bool with_pad;
@@ -420,7 +417,7 @@ void test_get_authz_data_types(void **state)
     krb5_free_principal(test_ctx->krb5_ctx, non_nfs_princ);
 }
 
-void test_string_to_sid(void **state)
+static void test_string_to_sid(void **state)
 {
     int ret;
     struct dom_sid sid;
@@ -452,7 +449,7 @@ void test_string_to_sid(void **state)
     assert_memory_equal(&exp_sid, &sid, sizeof(struct dom_sid));
 }
 
-void test_dom_sid_string(void **state)
+static void test_dom_sid_string(void **state)
 {
     struct test_ctx *test_ctx;
     char *str_sid;
-- 
2.26.3