From ff15df8bd58bddd4c53644867f8ee340febdc198 Mon Sep 17 00:00:00 2001
From: Petr Vobornik <pvoborni@redhat.com>
Date: Mon, 20 Jan 2014 09:50:56 +0100
Subject: [PATCH 33/34] Remove SID resolve call from Web UI

- it's called in group-show

https://bugzilla.redhat.com/show_bug.cgi?id=1054391
https://fedorahosted.org/freeipa/ticket/4123
---
 install/ui/src/freeipa/association.js | 47 -----------------------------------
 install/ui/src/freeipa/group.js       |  1 -
 2 files changed, 48 deletions(-)

diff --git a/install/ui/src/freeipa/association.js b/install/ui/src/freeipa/association.js
index ad427d66b6b98119b2eb577ae98e4b7c2f1a6932..8d81e495a153c06cdbcfa9917bdf04d70916f997 100644
--- a/install/ui/src/freeipa/association.js
+++ b/install/ui/src/freeipa/association.js
@@ -1455,53 +1455,6 @@ exp.attribute_facet = IPA.attribute_facet = function(spec, no_init) {
     return that;
 };
 
-IPA.sid_facet = function(spec, no_init) {
-
-    spec.name = spec.name || 'sid_facet';
-
-    var that = IPA.attribute_facet(spec, no_init);
-
-    that.load_records = function(value) {
-        var xlate = {};
-        var sidxlate_command = IPA.command({
-            entity: 'trust',
-            method: 'resolve',
-            options: {
-                sids: ''
-            }
-        });
-        sidxlate_command.on_success = function(data, text_status, xhr) {
-            for (var i=0; i< data.result.result.length; i++) {
-                var entry = data.result.result[i];
-                if (entry.sid[0] in xlate) {
-                    xlate[entry.sid[0]].resolve(entry.name[0]);
-                }
-            }
-        };
-        that.table.empty();
-
-        if (value.length === 0) return;
-
-        var sids = [];
-        for (var i=0; i< value.length; i++) {
-            var sid = value[i][that.attribute];
-            var deferred = new Deferred();
-            value[i][that.attribute] = {
-                promise: deferred.promise,
-                temp: sid
-            };
-            xlate[sid] = deferred;
-            sids.push(sid);
-            that.add_record(value[i]);
-        }
-        sidxlate_command.options.sids = sids;
-        sidxlate_command.execute();
-    };
-
-    return that;
-};
-
-
 IPA.attr_read_only_evaluator = function(spec) {
 
     spec.name = spec.name || 'attr_read_only_evaluator';
diff --git a/install/ui/src/freeipa/group.js b/install/ui/src/freeipa/group.js
index 5e8cdf991cdaf4f52e3f49dca431e999a72f2089..bb12d902fcba8228098b667aa6fbd3fa7daee34d 100644
--- a/install/ui/src/freeipa/group.js
+++ b/install/ui/src/freeipa/group.js
@@ -112,7 +112,6 @@ return {
         },
         {
             $type: 'attribute',
-            $factory: IPA.sid_facet,
             name: 'member_external',
             attribute: 'ipaexternalmember',
             tab_label: 'External',
-- 
1.8.4.2