From a8fde83022360a02e53b70fd7bd4d61de1ccc7cb Mon Sep 17 00:00:00 2001
From: Martin Kosek <mkosek@redhat.com>
Date: Fri, 7 Mar 2014 10:06:52 +0100
Subject: [PATCH 57/58] Avoid passing non-terminated string to is_master_host

When string is not terminated, queries with corrupted base may be sent
to LDAP:

... cn=ipa1.example.com<garbage>,cn=masters...

https://fedorahosted.org/freeipa/ticket/4214

Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
---
 daemons/ipa-kdb/ipa_kdb_mspac.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/daemons/ipa-kdb/ipa_kdb_mspac.c b/daemons/ipa-kdb/ipa_kdb_mspac.c
index 8481278760aba2d5dec5c337813f394633d67e46..a73a3cb46e104b43493177e333deb2b0d6226c2a 100644
--- a/daemons/ipa-kdb/ipa_kdb_mspac.c
+++ b/daemons/ipa-kdb/ipa_kdb_mspac.c
@@ -488,13 +488,14 @@ static krb5_error_code ipadb_fill_info3(struct ipadb_context *ipactx,
         }
 
         data = krb5_princ_component(ipactx->context, princ, 1);
-        strres = malloc(data->length);
+        strres = malloc(data->length+1);
         if (strres == NULL) {
             krb5_free_principal(ipactx->kcontext, princ);
             return ENOENT;
         }
 
         memcpy(strres, data->data, data->length);
+        strres[data->length] = '\0';
         krb5_free_principal(ipactx->kcontext, princ);
 
         /* Only add PAC to TGT to services on IPA masters to allow querying
-- 
1.8.5.3