From 38d8178482ea7dabf7c4ab8c2973faa2b469e9c7 Mon Sep 17 00:00:00 2001
From: Peter Jones <pjones@redhat.com>
Date: Thu, 2 Jul 2015 16:26:59 -0400
Subject: [PATCH 11/55] Don't leak from one extractTitle() call.

Found by coverity.

Signed-off-by: Peter Jones <pjones@redhat.com>
---
 grubby.c | 27 +++++++++++++++++----------
 1 file changed, 17 insertions(+), 10 deletions(-)

diff --git a/grubby.c b/grubby.c
index 0bb486967bf..70477ba14ee 100644
--- a/grubby.c
+++ b/grubby.c
@@ -1510,13 +1510,14 @@ static struct grubConfig * readConfig(const char * inName,
     return cfg;
 }
 
-static void writeDefault(FILE * out, char * indent, 
+static void writeDefault(FILE * out, char * indent,
 			 char * separator, struct grubConfig * cfg) {
     struct singleEntry * entry;
     struct singleLine * line;
     int i;
 
-    if (!cfg->defaultImage && cfg->flags == GRUB_CONFIG_NO_DEFAULT) return;
+    if (!cfg->defaultImage && cfg->flags == GRUB_CONFIG_NO_DEFAULT)
+	return;
 
     if (cfg->defaultImage == DEFAULT_SAVED)
 	fprintf(out, "%sdefault%ssaved\n", indent, separator);
@@ -1540,34 +1541,40 @@ static void writeDefault(FILE * out, char * indent,
 	        fprintf(out, "%sset default=\"%d\"\n", indent,
 			cfg->defaultImage);
 	    } else {
-		fprintf(out, "%sdefault%s%d\n", indent, separator, 
+		fprintf(out, "%sdefault%s%d\n", indent, separator,
 			cfg->defaultImage);
 	    }
 	} else {
 	    int image = cfg->defaultImage;
 
 	    entry = cfg->entries;
-	    while (entry && entry->skip) entry = entry->next;
+	    while (entry && entry->skip)
+		entry = entry->next;
 
 	    i = 0;
 	    while (entry && i < image) {
 		entry = entry->next;
 
-		while (entry && entry->skip) entry = entry->next;
+		while (entry && entry->skip)
+		    entry = entry->next;
 		i++;
 	    }
 
-	    if (!entry) return;
+	    if (!entry)
+		return;
 
 	    line = getLineByType(LT_TITLE, entry->lines);
 
 	    if (line && line->numElements >= 2)
-		fprintf(out, "%sdefault%s%s\n", indent, separator, 
+		fprintf(out, "%sdefault%s%s\n", indent, separator,
 			line->elements[1].item);
-            else if (line && (line->numElements == 1) && 
+            else if (line && (line->numElements == 1) &&
                      cfg->cfi->titleBracketed) {
-		fprintf(out, "%sdefault%s%s\n", indent, separator, 
-                        extractTitle(cfg, line));
+		char *title = extractTitle(cfg, line);
+		if (title) {
+		    fprintf(out, "%sdefault%s%s\n", indent, separator, title);
+		    free(title);
+		}
             }
 	}
     }
-- 
2.17.1