Blob Blame History Raw
From 4659ab64bf803f6dcef3fe93d2613d84ef62fa43 Mon Sep 17 00:00:00 2001
From: Ashish Pandey <aspandey@redhat.com>
Date: Wed, 17 Jun 2015 12:40:06 +0530
Subject: [PATCH 084/101]  ec: Display correct message after successful heal start

 Problem : While launching heal, it shows heal launch
 was unsuccessful. However, internaly it was successfully
 launched.

 Solution : Don't reset op_ret to -1 in for loop for
 every brick.
 Review link for master -
 http://review.gluster.org/11267

Change-Id: Iff89fdaf6082767ed67523a56430a9e83e6984d3
BUG: 1224137
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: https://code.engineering.redhat.com/gerrit/50892
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
---
 xlators/cluster/ec/src/ec-heald.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/xlators/cluster/ec/src/ec-heald.c b/xlators/cluster/ec/src/ec-heald.c
index a7cf8f7..bfdf959 100644
--- a/xlators/cluster/ec/src/ec-heald.c
+++ b/xlators/cluster/ec/src/ec-heald.c
@@ -541,10 +541,10 @@ ec_heal_op (xlator_t *this, dict_t *output, gf_xl_afr_op_t op, int xl_id)
 
         ec = this->private;
 
+        op_ret = -1;
         for (i = 0; i < ec->nodes; i++) {
                 snprintf (key, sizeof (key), "%d-%d-status", xl_id, i);
 
-                op_ret = -1;
                 if (((ec->xl_up >> i) & 1) == 0) {
                         ret = dict_set_str (output, key, "Brick is not connected");
                 } else if (!ec->up) {
-- 
1.7.1