Blob Blame History Raw
From 63e8fb2b6a3846c3f3a0e1db6275a8c03dbbc6ff Mon Sep 17 00:00:00 2001
From: Milind Changire <mchangir@redhat.com>
Date: Thu, 13 Dec 2018 10:00:45 +0530
Subject: [PATCH 473/493] rpc: bump up server.event-threads

Problem:
A single event-thread causes performance issues in the system.

Solution:
Bump up event-threads to 2 to make the system more performant.
This helps in making the system more responsive and helps avoid the
ping-timer-expiry problem as well. However, setting the event-threads
to 2 is not the only thing required to avoid ping-timer-expiry issues.

NOTE:
NFS xlator option nfs.event-threads does not yet exist here.

mainline:
> Change-Id: Idb0fd49e078db3bd5085dd083b0cdc77b59ddb00
> fixes: bz#1653277
> Signed-off-by: Milind Changire <mchangir@redhat.com>
> Reviewed-on: https://review.gluster.org/c/glusterfs/+/21719

Change-Id: Idb0fd49e078db3bd5085dd083b0cdc77b59ddb00
BUG: 1652537
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: https://code.engineering.redhat.com/gerrit/158482
Tested-by: RHGS Build Bot <nigelb@redhat.com>
Reviewed-by: Raghavendra Gowdappa <rgowdapp@redhat.com>
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
---
 libglusterfs/src/glusterfs.h         | 2 +-
 xlators/protocol/server/src/server.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/libglusterfs/src/glusterfs.h b/libglusterfs/src/glusterfs.h
index 3e2f426..d06d8cf 100644
--- a/libglusterfs/src/glusterfs.h
+++ b/libglusterfs/src/glusterfs.h
@@ -249,7 +249,7 @@ enum gf_internal_fop_indicator {
 
 #define GLUSTERFS_RPC_REPLY_SIZE               24
 
-#define STARTING_EVENT_THREADS                 1
+#define STARTING_EVENT_THREADS                 2
 
 #define DEFAULT_VAR_RUN_DIRECTORY        DATADIR "/run/gluster"
 #define DEFAULT_GLUSTERFSD_MISC_DIRETORY DATADIR "/lib/misc/glusterfsd"
diff --git a/xlators/protocol/server/src/server.c b/xlators/protocol/server/src/server.c
index 6f510ea..1046152 100644
--- a/xlators/protocol/server/src/server.c
+++ b/xlators/protocol/server/src/server.c
@@ -1932,7 +1932,7 @@ struct volume_options options[] = {
           .type  = GF_OPTION_TYPE_INT,
           .min   = 1,
           .max   = 1024,
-          .default_value = "1",
+          .default_value = "2",
           .description = "Specifies the number of event threads to execute "
                          "in parallel. Larger values would help process"
                          " responses faster, depending on available processing"
-- 
1.8.3.1