Blob Blame History Raw
From 8eb95b2ebdedd61e7784cf2f18b9564d2d4ed0b9 Mon Sep 17 00:00:00 2001
From: Milind Changire <mchangir@redhat.com>
Date: Thu, 13 Dec 2018 10:11:58 +0530
Subject: [PATCH 468/493] core: move invalid port logs to DEBUG log level

Stop spamming "invalid port" logs in case sysadmin has reserved a large
number of ports.

manline:
> Change-Id: I244ef7693560cc404b36cadc6b05d92ec0e908d3
> fixes: bz#1656517
> Signed-off-by: Milind Changire <mchangir@redhat.com>
> Reviewed-on: https://review.gluster.org/c/glusterfs/+/21809

Change-Id: I244ef7693560cc404b36cadc6b05d92ec0e908d3
BUG: 1656217
Signed-off-by: Milind Changire <mchangir@redhat.com>
Reviewed-on: https://code.engineering.redhat.com/gerrit/158483
Tested-by: RHGS Build Bot <nigelb@redhat.com>
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
---
 libglusterfs/src/common-utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libglusterfs/src/common-utils.c b/libglusterfs/src/common-utils.c
index 25600a9..1243754 100644
--- a/libglusterfs/src/common-utils.c
+++ b/libglusterfs/src/common-utils.c
@@ -3373,7 +3373,7 @@ gf_ports_reserved (char *blocked_port, unsigned char *ports, uint32_t ceiling)
                 if (blocked_port[strlen(blocked_port) -1] == '\n')
                         blocked_port[strlen(blocked_port) -1] = '\0';
                 if (gf_string2int32 (blocked_port, &tmp_port1) == 0) {
-                        if (tmp_port1 > ceiling
+                        if (tmp_port1 > GF_PORT_MAX
                             || tmp_port1 < 0) {
                                 gf_msg ("glusterfs-socket", GF_LOG_WARNING, 0,
                                         LG_MSG_INVALID_PORT, "invalid port %d",
-- 
1.8.3.1