Blob Blame History Raw
From 5ac5b5347400bbb8111ce059389af31e7b7b2904 Mon Sep 17 00:00:00 2001
From: "Kaleb S. KEITHLEY" <kkeithle@redhat.com>
Date: Tue, 13 Jun 2017 09:02:00 -0400
Subject: [PATCH 513/525] common-ha: surviving ganesha.nfsd not put in grace on
 fail-over

Behavior change is seen in new HA in RHEL 7.4 Beta. Up to now clone
RAs have been created with "pcs resource create ... meta notify=true".
Their notify method is invoked with pre-start or post-stop when one of
the clone RAs is started or stopped.

In 7.4 Beta we observe that the notify method is not invoked when one
of the clones is stopped (or started).

Ken Gaillot, one of the pacemaker devs, wrote:
  With the above command, pcs puts the notify=true meta-attribute
  on the primitive instead of the clone. Looking at the pcs help,
  that seems expected (--clone notify=true would put it on the clone,
  meta notify=true puts it on the primitive). If you drop the "meta"
  above, I think it will work again.

And indeed his suggested fix does work on both RHEL 7.4 Beta and RHEL
7.3 and presumably Fedora.

Upstream BZ: 1461019
Upstream Change-Id: Idbb539f1366df6d39f77431c357dff4e53a2df6d
Upstream: https://review.gluster.org/#/c/17534/
BUG: 1457179
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>

Change-Id: I81b808e542b38d39ff916f11c693bd22b5e9cbeb
Reviewed-on: https://code.engineering.redhat.com/gerrit/108924
Tested-by: Kaleb Keithley <kkeithle@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
---
 extras/ganesha/scripts/ganesha-ha.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/extras/ganesha/scripts/ganesha-ha.sh b/extras/ganesha/scripts/ganesha-ha.sh
index 138af51..130a584 100644
--- a/extras/ganesha/scripts/ganesha-ha.sh
+++ b/extras/ganesha/scripts/ganesha-ha.sh
@@ -424,7 +424,7 @@ setup_create_resources()
     # ganesha-active crm_attribute
     sleep 5
 
-    pcs resource create nfs-grace ocf:heartbeat:ganesha_grace --clone meta notify=true
+    pcs resource create nfs-grace ocf:heartbeat:ganesha_grace --clone notify=true
     if [ $? -ne 0 ]; then
         logger "warning: pcs resource create nfs-grace ocf:heartbeat:ganesha_grace --clone failed"
     fi
-- 
1.8.3.1