Blob Blame History Raw
From 8003a0731acd44f69f7d9652b217097cc396620c Mon Sep 17 00:00:00 2001
From: Jiffin Tony Thottan <jthottan@redhat.com>
Date: Tue, 2 May 2017 14:06:00 +0530
Subject: [PATCH 410/426] glusterd/ganesha : add proper NULL check in
 manage_export_config

Upstream reference :
>Change-Id: I872b2b6b027f04e61f60ad85588f50e1ef2f988c
>BUG: 1425723
>Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
>Reviewed-on: https://review.gluster.org/17150
>Smoke: Gluster Build System <jenkins@build.gluster.org>
>Reviewed-by: soumya k <skoduri@redhat.com>
>NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
>Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
>CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
>Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>

Change-Id: I872b2b6b027f04e61f60ad85588f50e1ef2f988c
BUG: 1446645
Signed-off-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-on: https://code.engineering.redhat.com/gerrit/104975
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
---
 xlators/mgmt/glusterd/src/glusterd-ganesha.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xlators/mgmt/glusterd/src/glusterd-ganesha.c b/xlators/mgmt/glusterd/src/glusterd-ganesha.c
index b7a6db4..f74b784 100644
--- a/xlators/mgmt/glusterd/src/glusterd-ganesha.c
+++ b/xlators/mgmt/glusterd/src/glusterd-ganesha.c
@@ -467,7 +467,7 @@ manage_export_config (char *volname, char *value, char **op_errstr)
                         CONFDIR, value, volname, NULL);
         ret = runner_run(&runner);
 
-        if (ret && !(*op_errstr))
+        if (ret && op_errstr)
                 gf_asprintf (op_errstr, "Failed to create"
                             " NFS-Ganesha export config file.");
 
-- 
1.8.3.1