Blob Blame History Raw
From 50c7c78e8e70396cf7da8f3cf05a2814b2953926 Mon Sep 17 00:00:00 2001
From: Atin Mukherjee <amukherj@redhat.com>
Date: Tue, 21 Feb 2017 18:33:14 +0530
Subject: [PATCH 337/361] glusterd: unref brickinfo object on volume stop

If brick multiplexing is enabled, on a volume stop glusterd was not
unrefing the brickinfo rpc object which lead to a flood of stale rpc
logs.

mainline:
> BUG: 1421724
> Reviewed-on: https://review.gluster.org/16699
> Smoke: Gluster Build System <jenkins@build.gluster.org>
> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
> CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
> Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
> Reviewed-by: Samikshan Bairagya <samikshan@gmail.com>
(cherry picked from commit 16b342a7536e67f30b11258849cae8f9459bc518)

BUG: 1417815
Change-Id: I18fedcd6921042ef2e945605466194b7b53fe2f7
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://code.engineering.redhat.com/gerrit/101318
Tested-by: Milind Changire <mchangir@redhat.com>
---
 xlators/mgmt/glusterd/src/glusterd-utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xlators/mgmt/glusterd/src/glusterd-utils.c b/xlators/mgmt/glusterd/src/glusterd-utils.c
index 66b3d54..42887e9 100644
--- a/xlators/mgmt/glusterd/src/glusterd-utils.c
+++ b/xlators/mgmt/glusterd/src/glusterd-utils.c
@@ -2105,8 +2105,8 @@ glusterd_volume_stop_glusterfs (glusterd_volinfo_t  *volinfo,
                         if (op_errstr) {
                                 GF_FREE (op_errstr);
                         }
-                        (void) glusterd_brick_disconnect (brickinfo);
                 }
+                (void) glusterd_brick_disconnect (brickinfo);
                 ret = 0;
         }
 
-- 
1.8.3.1