Blob Blame History Raw
From 0b276276d915bab7dd72a83caf1e5f11c8c543ae Mon Sep 17 00:00:00 2001
From: Niels de Vos <ndevos@redhat.com>
Date: Thu, 21 Jul 2016 08:12:04 +0200
Subject: [PATCH 117/141] md-cache: fix indention to silence Coverity

Coverity complains about the incorrect indention:

    *** CID 1357867:  Control flow issues  (NESTING_INDENT_MISMATCH)
    ...
    2566                     if (conf->mdc_invalidation)
    2567                             ret = mdc_invalidate (this, data);
    >>>     CID 1357867:  Control flow issues  (NESTING_INDENT_MISMATCH)
    >>>     This 'if'  statement is indented to column 25, as if it were nested within the preceding parent statement, but it is not.
    2568                             if (default_notify (this, event, data) != 0)
    2569      	                         ret = -1;
    2570                     break;
    ...

Even when md-cache does not have cache-invalidation on, we need to pass
the upcall to the next xlator.

Change-Id: I6d2a174eb54e3df270920aae9673b5010c235f25
CID: 1357867
BUG: 1284873
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: http://review.gluster.org/14971
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Poornima G <pgurusid@redhat.com>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: https://code.engineering.redhat.com/gerrit/87030
Reviewed-by: Rajesh Joseph <rjoseph@redhat.com>
Tested-by: Rajesh Joseph <rjoseph@redhat.com>
---
 xlators/performance/md-cache/src/md-cache.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/xlators/performance/md-cache/src/md-cache.c b/xlators/performance/md-cache/src/md-cache.c
index fd2b366..12a383d 100644
--- a/xlators/performance/md-cache/src/md-cache.c
+++ b/xlators/performance/md-cache/src/md-cache.c
@@ -2581,8 +2581,8 @@ notify (xlator_t *this, int event, void *data, ...)
         case GF_EVENT_UPCALL:
                 if (conf->mdc_invalidation)
                         ret = mdc_invalidate (this, data);
-                        if (default_notify (this, event, data) != 0)
-                                ret = -1;
+                if (default_notify (this, event, data) != 0)
+                        ret = -1;
                 break;
         default:
                 ret = default_notify (this, event, data);
-- 
1.7.1