Blob Blame History Raw
From 94f12a1f78b86ff0c597c29c91d020732ce68df3 Mon Sep 17 00:00:00 2001
From: Vasu Dev <vasu.dev@intel.com>
Date: Fri, 30 Jan 2015 14:29:19 -0800
Subject: [PATCH] fipvlan: fix broken fcoe start using fipvlan

FCoE start is broken due to the link being never selected and that
is in turn due to bad vlan interface name compare against real
interface name passed for fip vlan discovery.

This name compare is unnecessary and breaks fipvlan start option,
so this patch removes it to have fcoe start working again.

I considered reducing compare to just the base real interface name
but that won't work in the case of existing vlan interface name is
already customized, so instead just don't check for the name.

I verified this fixes the start using newly created vlan as well
as existing vlan, which could be down or already running.

Signed-off-by: Vasu Dev <vasu.dev@intel.com>
---
 fipvlan.c | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/fipvlan.c b/fipvlan.c
index 4937173..9e494ee 100644
--- a/fipvlan.c
+++ b/fipvlan.c
@@ -448,19 +448,6 @@ static void rtnl_recv_newlink(struct nlmsghdr *nh)
 	memcpy(iff->mac_addr, RTA_DATA(ifla[IFLA_ADDRESS]), ETHER_ADDR_LEN);
 	strncpy(iff->ifname, RTA_DATA(ifla[IFLA_IFNAME]), IFNAMSIZ);
 
-	if (!config.automode) {
-		int i, iff_selected = 0;
-
-		for (i = 0; i < config.namec; i++) {
-			if (!strcmp(iff->ifname, config.namev[i]))
-				iff_selected = 1;
-		}
-		if (!iff_selected) {
-			FIP_LOG_DBG("ignoring if %s\n", iff->ifname);
-			free(iff);
-			return;
-		}
-	}
 	if (ifla[IFLA_LINKINFO]) {
 		parse_linkinfo(linkinfo, ifla[IFLA_LINKINFO]);
 		/* Track VLAN devices separately */
-- 
2.1.0