| From c5ee3f3aab59ff26b0fed770077a16714da9696e Mon Sep 17 00:00:00 2001 |
| From: Gerd Hoffmann <kraxel@redhat.com> |
| Date: Thu, 28 Apr 2016 16:07:27 +0200 |
| Subject: [PATCH 22/27] vga: Remove some "should be done in BIOS" comments |
| |
| RH-Author: Gerd Hoffmann <kraxel@redhat.com> |
| Message-id: <1461859652-20918-2-git-send-email-kraxel@redhat.com> |
| Patchwork-id: 70292 |
| O-Subject: [virt-devel] [RHEL-7.3 qemu-kvm PATCH 1/6] vga: Remove some "should be done in BIOS" comments |
| Bugzilla: 1331413 |
| RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com> |
| RH-Acked-by: Laszlo Ersek <lersek@redhat.com> |
| RH-Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com> |
| |
| From: Benjamin Herrenschmidt <benh@kernel.crashing.org> |
| |
| Not all platforms have a VGA BIOS, powerpc typically relies on |
| using the DISPI interface to initialize the card. |
| |
| Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> |
| Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> |
| Reviewed-by: David Gibson <david@gibson.dropbear.id.au> |
| (cherry picked from commit ace89b8ff21cc3fb20986a334e54e6e6a1ccf729) |
| Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com> |
| |
| hw/display/vga.c | 6 ++---- |
| 1 file changed, 2 insertions(+), 4 deletions(-) |
| |
| diff --git a/hw/display/vga.c b/hw/display/vga.c |
| index 0761b9e..48dad03 100644 |
| |
| |
| @@ -764,14 +764,13 @@ void vbe_ioport_write_data(void *opaque, uint32_t addr, uint32_t val) |
| s->vbe_regs[VBE_DISPI_INDEX_ENABLE] |= VBE_DISPI_ENABLED; |
| vbe_fixup_regs(s); |
| |
| - /* clear the screen (should be done in BIOS) */ |
| + /* clear the screen */ |
| if (!(val & VBE_DISPI_NOCLEARMEM)) { |
| memset(s->vram_ptr, 0, |
| s->vbe_regs[VBE_DISPI_INDEX_YRES] * s->vbe_line_offset); |
| } |
| |
| - /* we initialize the VGA graphic mode (should be done |
| - in BIOS) */ |
| + /* we initialize the VGA graphic mode */ |
| /* graphic mode + memory map 1 */ |
| s->gr[VGA_GFX_MISC] = (s->gr[VGA_GFX_MISC] & ~0x0c) | 0x04 | |
| VGA_GR06_GRAPHICS_MODE; |
| @@ -804,7 +803,6 @@ void vbe_ioport_write_data(void *opaque, uint32_t addr, uint32_t val) |
| (shift_control << 5); |
| s->cr[VGA_CRTC_MAX_SCAN] &= ~0x9f; /* no double scan */ |
| } else { |
| - /* XXX: the bios should do that */ |
| s->bank_offset = 0; |
| } |
| s->dac_8bit = (val & VBE_DISPI_8BIT_DAC) > 0; |
| -- |
| 1.8.3.1 |
| |