From b5ce0e989440de2c3d4bfb8b325d85ca25ace4ca Mon Sep 17 00:00:00 2001
Message-Id: <b5ce0e989440de2c3d4bfb8b325d85ca25ace4ca@dist-git>
From: Pavel Hrdina <phrdina@redhat.com>
Date: Mon, 1 Jul 2019 17:07:38 +0200
Subject: [PATCH] vircgroup: introduce virCgroupV2(Set|Get)BlkioDeviceWriteBps
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
(cherry picked from commit 91756fb64a370e48a6bcdd1973126a8c7a36e4f7)
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1689297
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Message-Id: <3d70ebb985fa8132e45ba12bbb8e78ac80557a78.1561993100.git.phrdina@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---
src/util/vircgroupv2.c | 70 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 70 insertions(+)
diff --git a/src/util/vircgroupv2.c b/src/util/vircgroupv2.c
index b303e9cb10..52d31925c2 100644
--- a/src/util/vircgroupv2.c
+++ b/src/util/vircgroupv2.c
@@ -947,6 +947,74 @@ virCgroupV2GetBlkioDeviceReadBps(virCgroupPtr group,
}
+static int
+virCgroupV2SetBlkioDeviceWriteBps(virCgroupPtr group,
+ const char *path,
+ unsigned long long wbps)
+{
+ VIR_AUTOFREE(char *) str = NULL;
+ VIR_AUTOFREE(char *) blkstr = NULL;
+
+ if (!(blkstr = virCgroupGetBlockDevString(path)))
+ return -1;
+
+ if (wbps == 0) {
+ if (virAsprintf(&str, "%swbps=max", blkstr) < 0)
+ return -1;
+ } else {
+ if (virAsprintf(&str, "%swbps=%llu", blkstr, wbps) < 0)
+ return -1;
+ }
+
+ return virCgroupSetValueStr(group,
+ VIR_CGROUP_CONTROLLER_BLKIO,
+ "io.max",
+ str);
+}
+
+
+static int
+virCgroupV2GetBlkioDeviceWriteBps(virCgroupPtr group,
+ const char *path,
+ unsigned long long *wbps)
+{
+ VIR_AUTOFREE(char *) str = NULL;
+ const char *name = "wbps=";
+ char *tmp;
+
+ if (virCgroupGetValueForBlkDev(group,
+ VIR_CGROUP_CONTROLLER_BLKIO,
+ "io.max",
+ path,
+ &str) < 0) {
+ return -1;
+ }
+
+ if (!str) {
+ *wbps = 0;
+ } else {
+ if (!(tmp = strstr(str, name))) {
+ virReportError(VIR_ERR_INTERNAL_ERROR,
+ _("Unable to find '%s' limit for block device '%s'"),
+ name, path);
+ return -1;
+ }
+ tmp += strlen(name);
+
+ if (STREQLEN(tmp, "max", 3)) {
+ *wbps = 0;
+ } else if (virStrToLong_ull(tmp, NULL, 10, wbps) < 0) {
+ virReportError(VIR_ERR_INTERNAL_ERROR,
+ _("Unable to parse '%s' as an integer"),
+ str);
+ return -1;
+ }
+ }
+
+ return 0;
+}
+
+
virCgroupBackend virCgroupV2Backend = {
.type = VIR_CGROUP_BACKEND_TYPE_V2,
@@ -981,6 +1049,8 @@ virCgroupBackend virCgroupV2Backend = {
.getBlkioDeviceWriteIops = virCgroupV2GetBlkioDeviceWriteIops,
.setBlkioDeviceReadBps = virCgroupV2SetBlkioDeviceReadBps,
.getBlkioDeviceReadBps = virCgroupV2GetBlkioDeviceReadBps,
+ .setBlkioDeviceWriteBps = virCgroupV2SetBlkioDeviceWriteBps,
+ .getBlkioDeviceWriteBps = virCgroupV2GetBlkioDeviceWriteBps,
};
--
2.22.0