mrc0mmand / rpms / libguestfs

Forked from rpms/libguestfs 3 years ago
Clone
Blob Blame History Raw
From 54a616cfb842a8203e03ff1db54a179d6ca133ce Mon Sep 17 00:00:00 2001
From: "Richard W.M. Jones" <rjones@redhat.com>
Date: Fri, 2 Aug 2013 15:16:10 +0100
Subject: [PATCH] sysprep: Disable fs-uuids operation by default.

Disable this operation because it is more likely than not to break
Linux guests.

To fix this properly will involve finding all the places in the guest
where the UUIDs are used to locate and mount filesystems,
eg. /etc/fstab and possibly initramfs.

This updates commit 8965368eb89532ac1613fffb0a3a661f005bae81.

(cherry picked from commit 5deea7fce675edb6803cd83a699b80e8ea383488)
---
 sysprep/sysprep_operation_fs_uuids.ml | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/sysprep/sysprep_operation_fs_uuids.ml b/sysprep/sysprep_operation_fs_uuids.ml
index 3c319f0..9cdf576 100644
--- a/sysprep/sysprep_operation_fs_uuids.ml
+++ b/sysprep/sysprep_operation_fs_uuids.ml
@@ -42,7 +42,12 @@ let rec fs_uuids_perform g root =
 
 let fs_uuids_op = {
   name = "fs-uuids";
-  enabled_by_default = true;
+  (* NB: This is disabled by default now because doing this
+   * properly requires us to find all places in the image
+   * where the UUID might be used.  This includes /etc/fstab
+   * and possibly the initramfs.  XXX
+   *)
+  enabled_by_default = false;
   heading = s_"Change filesystem UUIDs";
   pod_description = Some (s_"\
 On guests and filesystem types where this is supported,
-- 
1.8.3.1