doczkal / rpms / abrt

Forked from rpms/abrt 4 years ago
Clone
Blob Blame History Raw
From 2acf4b7691165003cae6308f006cef329802f79e Mon Sep 17 00:00:00 2001
From: Matej Habrnal <mhabrnal@redhat.com>
Date: Tue, 5 Apr 2016 14:51:28 +0200
Subject: [PATCH] lib: prevent from creating non-root sub-dirs in dump dir

In the case an uid element doesn't exist in time of dump dir creating, we have
to create dump dir owned by root.

Related to rhbz#1264921

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
---
 src/lib/hooklib.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/lib/hooklib.c b/src/lib/hooklib.c
index 160a011..ed1607d 100644
--- a/src/lib/hooklib.c
+++ b/src/lib/hooklib.c
@@ -415,7 +415,12 @@ char* problem_data_save(problem_data_t *pd)
     if (g_settings_privatereports)
         dd = create_dump_dir_from_problem_data_ext(pd, g_settings_dump_location, 0);
     else
-        dd = create_dump_dir_from_problem_data(pd, g_settings_dump_location);
+    {
+        if (problem_data_get_content_or_NULL(pd, FILENAME_UID) == NULL)
+            dd = create_dump_dir_from_problem_data_ext(pd, g_settings_dump_location, 0);
+        else
+            dd = create_dump_dir_from_problem_data(pd, g_settings_dump_location);
+    }
 
     char *problem_id = NULL;
     if (dd)
-- 
1.8.3.1