|
 |
ad2f2b |
From d7d1c089196e4e1bef314d6d6a01caffd6bba1da Mon Sep 17 00:00:00 2001
|
|
|
ad2f2b |
From: Tomas Popela <tpopela@redhat.com>
|
|
|
ad2f2b |
Date: Mon, 23 Jul 2018 10:57:33 +0200
|
|
|
ad2f2b |
Subject: [PATCH 06/17] Fix a use of an uninitialized variable
|
|
|
ad2f2b |
|
|
|
ad2f2b |
yelp-3.28.1/libyelp/yelp-info-parser.c:1174: var_decl: Declaring variable "menu_node" without initializer.
|
|
|
ad2f2b |
yelp-3.28.1/libyelp/yelp-info-parser.c:1310: uninit_use: Using uninitialized value "menu_node".
|
|
|
ad2f2b |
1308| else if (*(menuitems[i]) != '\0') {
|
|
|
ad2f2b |
1309| tmp = g_strconcat ("\n", first_non_space (menuitems[i]), NULL);
|
|
|
ad2f2b |
1310|-> xmlNewTextChild (mholder ? mholder : menu_node,
|
|
|
ad2f2b |
1311| NULL, BAD_CAST "para1",
|
|
|
ad2f2b |
1312| BAD_CAST tmp);
|
|
|
ad2f2b |
---
|
|
|
ad2f2b |
libyelp/yelp-info-parser.c | 2 +-
|
|
|
ad2f2b |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
ad2f2b |
|
|
|
ad2f2b |
diff --git a/libyelp/yelp-info-parser.c b/libyelp/yelp-info-parser.c
|
|
|
ad2f2b |
index 0c383bfe..ed16e373 100644
|
|
|
ad2f2b |
--- a/libyelp/yelp-info-parser.c
|
|
|
ad2f2b |
+++ b/libyelp/yelp-info-parser.c
|
|
|
ad2f2b |
@@ -1171,7 +1171,7 @@ yelp_info_parse_menu (GtkTreeStore *tree, xmlNodePtr *node,
|
|
|
ad2f2b |
gchar **split;
|
|
|
ad2f2b |
gchar **menuitems;
|
|
|
ad2f2b |
gchar *tmp = NULL;
|
|
|
ad2f2b |
- xmlNodePtr newnode, menu_node, mholder = NULL;
|
|
|
ad2f2b |
+ xmlNodePtr newnode, menu_node = NULL, mholder = NULL;
|
|
|
ad2f2b |
int i=0;
|
|
|
ad2f2b |
|
|
|
ad2f2b |
split = g_strsplit (page_content, "* Menu:", 2);
|
|
|
ad2f2b |
--
|
|
|
ad2f2b |
2.19.1
|
|
|
ad2f2b |
|