|
 |
ad2f2b |
From 92974634d285448bbf2007a9bcfedf247a26a39b Mon Sep 17 00:00:00 2001
|
|
|
ad2f2b |
From: Tomas Popela <tpopela@redhat.com>
|
|
|
ad2f2b |
Date: Mon, 23 Jul 2018 10:55:52 +0200
|
|
|
ad2f2b |
Subject: [PATCH 05/17] Check whether variable node is set before dereferencing
|
|
|
ad2f2b |
it
|
|
|
ad2f2b |
|
|
|
ad2f2b |
yelp-3.28.1/libyelp/yelp-info-parser.c:766: dereference: Dereferencing a pointer that might be null "node" when calling "strncmp".
|
|
|
ad2f2b |
---
|
|
|
ad2f2b |
libyelp/yelp-info-parser.c | 4 ++--
|
|
|
ad2f2b |
1 file changed, 2 insertions(+), 2 deletions(-)
|
|
|
ad2f2b |
|
|
|
ad2f2b |
diff --git a/libyelp/yelp-info-parser.c b/libyelp/yelp-info-parser.c
|
|
|
ad2f2b |
index d0e767bc..0c383bfe 100644
|
|
|
ad2f2b |
--- a/libyelp/yelp-info-parser.c
|
|
|
ad2f2b |
+++ b/libyelp/yelp-info-parser.c
|
|
|
ad2f2b |
@@ -734,7 +734,7 @@ process_page (GtkTreeStore *tree,
|
|
|
ad2f2b |
g_free (next);
|
|
|
ad2f2b |
next = NULL;
|
|
|
ad2f2b |
}
|
|
|
ad2f2b |
- if (g_str_equal (node, "Top") && prev != NULL) {
|
|
|
ad2f2b |
+ if (node && g_str_equal (node, "Top") && prev != NULL) {
|
|
|
ad2f2b |
g_free (prev);
|
|
|
ad2f2b |
prev = NULL;
|
|
|
ad2f2b |
}
|
|
|
ad2f2b |
@@ -763,7 +763,7 @@ process_page (GtkTreeStore *tree,
|
|
|
ad2f2b |
}
|
|
|
ad2f2b |
if (prev && g_ascii_strncasecmp (prev, "(dir)", 5))
|
|
|
ad2f2b |
{
|
|
|
ad2f2b |
- if (strncmp (node, "Top", 3)) {
|
|
|
ad2f2b |
+ if (node && strncmp (node, "Top", 3)) {
|
|
|
ad2f2b |
/* Special case the Top node to always appear first */
|
|
|
ad2f2b |
} else {
|
|
|
ad2f2b |
page = node2page (nodes2pages, prev);
|
|
|
ad2f2b |
--
|
|
|
ad2f2b |
2.19.1
|
|
|
ad2f2b |
|