|
 |
dddf95 |
From 6dee7eadd1b7352ec503ea04fa1639d4a93f370b Mon Sep 17 00:00:00 2001
|
|
|
dddf95 |
From: Nils Philippsen <nils@redhat.com>
|
|
|
dddf95 |
Date: Thu, 16 Aug 2012 11:18:31 +0200
|
|
|
dddf95 |
Subject: [PATCH] patch: close-fds
|
|
|
dddf95 |
|
|
|
dddf95 |
Squashed commit of the following:
|
|
|
dddf95 |
|
|
|
dddf95 |
commit 4fdedd3a8b66fb42b2d4dde62df28c78571c1c5d
|
|
|
dddf95 |
Author: Nils Philippsen <nils@redhat.com>
|
|
|
dddf95 |
Date: Fri Nov 19 12:15:58 2010 +0100
|
|
|
dddf95 |
|
|
|
dddf95 |
don't leak file descriptors to help browser process (#455450)
|
|
|
dddf95 |
---
|
|
|
dddf95 |
src/xsane.c | 43 +++++++++++++++++++++++++++++++++++++++++++
|
|
|
dddf95 |
1 file changed, 43 insertions(+)
|
|
|
dddf95 |
|
|
|
dddf95 |
diff --git a/src/xsane.c b/src/xsane.c
|
|
|
dddf95 |
index 775610e..1c5d61d 100644
|
|
|
dddf95 |
--- a/src/xsane.c
|
|
|
dddf95 |
+++ b/src/xsane.c
|
|
|
dddf95 |
@@ -48,6 +48,8 @@
|
|
|
dddf95 |
|
|
|
dddf95 |
#include <sys/wait.h>
|
|
|
dddf95 |
|
|
|
dddf95 |
+#include <stdarg.h>
|
|
|
dddf95 |
+
|
|
|
dddf95 |
/* ---------------------------------------------------------------------------------------------------------------------- */
|
|
|
dddf95 |
|
|
|
dddf95 |
struct option long_options[] =
|
|
|
dddf95 |
@@ -3684,6 +3686,41 @@ static void xsane_show_gpl(GtkWidget *widget, gpointer data)
|
|
|
dddf95 |
|
|
|
dddf95 |
/* ---------------------------------------------------------------------------------------------------------------------- */
|
|
|
dddf95 |
|
|
|
dddf95 |
+static void xsane_close_fds_for_exec(signed int first_fd_to_leave_open, ...)
|
|
|
dddf95 |
+{
|
|
|
dddf95 |
+ int open_max;
|
|
|
dddf95 |
+ signed int i;
|
|
|
dddf95 |
+
|
|
|
dddf95 |
+ va_list ap;
|
|
|
dddf95 |
+ unsigned char *close_fds;
|
|
|
dddf95 |
+
|
|
|
dddf95 |
+ open_max = (int) sysconf (_SC_OPEN_MAX);
|
|
|
dddf95 |
+
|
|
|
dddf95 |
+ close_fds = malloc (open_max);
|
|
|
dddf95 |
+
|
|
|
dddf95 |
+ memset (close_fds, 1, open_max);
|
|
|
dddf95 |
+
|
|
|
dddf95 |
+ va_start (ap, first_fd_to_leave_open);
|
|
|
dddf95 |
+
|
|
|
dddf95 |
+ for (i = first_fd_to_leave_open; i >= 0; i = va_arg (ap, signed int)) {
|
|
|
dddf95 |
+ if (i < open_max)
|
|
|
dddf95 |
+ close_fds[i] = 0;
|
|
|
dddf95 |
+ }
|
|
|
dddf95 |
+
|
|
|
dddf95 |
+ va_end (ap);
|
|
|
dddf95 |
+
|
|
|
dddf95 |
+ DBG(DBG_info, "closing unneeded file descriptors\n");
|
|
|
dddf95 |
+
|
|
|
dddf95 |
+ for (i = 0; i < open_max; i++) {
|
|
|
dddf95 |
+ if (close_fds[i])
|
|
|
dddf95 |
+ close (i);
|
|
|
dddf95 |
+ }
|
|
|
dddf95 |
+
|
|
|
dddf95 |
+ free (close_fds);
|
|
|
dddf95 |
+}
|
|
|
dddf95 |
+
|
|
|
dddf95 |
+/* ---------------------------------------------------------------------------------------------------------------------- */
|
|
|
dddf95 |
+
|
|
|
dddf95 |
static void xsane_show_doc_via_nsr(GtkWidget *widget, gpointer data) /* show via netscape remote */
|
|
|
dddf95 |
{
|
|
|
dddf95 |
char *name = (char *) data;
|
|
|
dddf95 |
@@ -3736,6 +3773,8 @@ static void xsane_show_doc_via_nsr(GtkWidget *widget, gpointer data) /* show via
|
|
|
dddf95 |
ipc_file = fdopen(xsane.ipc_pipefd[1], "w");
|
|
|
dddf95 |
}
|
|
|
dddf95 |
|
|
|
dddf95 |
+ xsane_close_fds_for_exec (1, 2, xsane.ipc_pipefd[1], -1);
|
|
|
dddf95 |
+
|
|
|
dddf95 |
DBG(DBG_info, "trying to change user id for new subprocess:\n");
|
|
|
dddf95 |
DBG(DBG_info, "old effective uid = %d\n", (int) geteuid());
|
|
|
dddf95 |
setuid(getuid());
|
|
|
dddf95 |
@@ -3778,6 +3817,8 @@ static void xsane_show_doc_via_nsr(GtkWidget *widget, gpointer data) /* show via
|
|
|
dddf95 |
ipc_file = fdopen(xsane.ipc_pipefd[1], "w");
|
|
|
dddf95 |
}
|
|
|
dddf95 |
|
|
|
dddf95 |
+ xsane_close_fds_for_exec (1, 2, xsane.ipc_pipefd[1], -1);
|
|
|
dddf95 |
+
|
|
|
dddf95 |
DBG(DBG_info, "trying to change user id for new subprocess:\n");
|
|
|
dddf95 |
DBG(DBG_info, "old effective uid = %d\n", (int) geteuid());
|
|
|
dddf95 |
setuid(getuid());
|
|
|
dddf95 |
@@ -3899,6 +3940,8 @@ static void xsane_show_doc(GtkWidget *widget, gpointer data)
|
|
|
dddf95 |
ipc_file = fdopen(xsane.ipc_pipefd[1], "w");
|
|
|
dddf95 |
}
|
|
|
dddf95 |
|
|
|
dddf95 |
+ xsane_close_fds_for_exec (1, 2, xsane.ipc_pipefd[1], -1);
|
|
|
dddf95 |
+
|
|
|
dddf95 |
DBG(DBG_info, "trying to change user id for new subprocess:\n");
|
|
|
dddf95 |
DBG(DBG_info, "old effective uid = %d\n", (int) geteuid());
|
|
|
dddf95 |
setuid(getuid());
|
|
|
dddf95 |
--
|
|
|
dddf95 |
1.7.11.4
|
|
|
dddf95 |
|