Blame SOURCES/0010-modesetting-Fix-build-with-glamor-disabled.patch

cf7b2a
From d8271417a5986240f1f81cbe269e0cd07a9104d1 Mon Sep 17 00:00:00 2001
cf7b2a
From: =?UTF-8?q?Michel=20D=C3=A4nzer?= <mdaenzer@redhat.com>
cf7b2a
Date: Mon, 10 Feb 2020 18:41:44 +0100
cf7b2a
Subject: [PATCH xserver 10/11] modesetting: Fix build with glamor disabled
cf7b2a
cf7b2a
Fixes: cb1b1e184723 "modesetting: Indirect the glamor API through
cf7b2a
                     LoaderSymbol"
cf7b2a
Reviewed-by: Adam Jackson <ajax@redhat.com>
cf7b2a
(cherry picked from commit 0cb9fa7949d6c5398de220fbdbe1e262e943fcbb)
cf7b2a
---
cf7b2a
 hw/xfree86/drivers/modesetting/driver.c | 21 +++++++++++++++------
cf7b2a
 hw/xfree86/drivers/modesetting/driver.h |  3 ++-
cf7b2a
 2 files changed, 17 insertions(+), 7 deletions(-)
cf7b2a
cf7b2a
diff --git a/hw/xfree86/drivers/modesetting/driver.c b/hw/xfree86/drivers/modesetting/driver.c
cf7b2a
index 08cf6a1b4..ce8bac9f5 100644
cf7b2a
--- a/hw/xfree86/drivers/modesetting/driver.c
cf7b2a
+++ b/hw/xfree86/drivers/modesetting/driver.c
cf7b2a
@@ -743,9 +743,17 @@ FreeRec(ScrnInfoPtr pScrn)
cf7b2a
 
cf7b2a
 }
cf7b2a
 
cf7b2a
-static void
cf7b2a
-bind_glamor_api(void *mod, modesettingPtr ms)
cf7b2a
+#ifdef GLAMOR_HAS_GBM
cf7b2a
+
cf7b2a
+static Bool
cf7b2a
+load_glamor(ScrnInfoPtr pScrn)
cf7b2a
 {
cf7b2a
+    void *mod = xf86LoadSubModule(pScrn, GLAMOR_EGL_MODULE_NAME);
cf7b2a
+    modesettingPtr ms = modesettingPTR(pScrn);
cf7b2a
+
cf7b2a
+    if (!mod)
cf7b2a
+        return FALSE;
cf7b2a
+
cf7b2a
     ms->glamor.back_pixmap_from_fd = LoaderSymbolFromModule(mod, "glamor_back_pixmap_from_fd");
cf7b2a
     ms->glamor.block_handler = LoaderSymbolFromModule(mod, "glamor_block_handler");
cf7b2a
     ms->glamor.egl_create_textured_pixmap = LoaderSymbolFromModule(mod, "glamor_egl_create_textured_pixmap");
cf7b2a
@@ -762,8 +770,12 @@ bind_glamor_api(void *mod, modesettingPtr ms)
cf7b2a
     ms->glamor.supports_pixmap_import_export = LoaderSymbolFromModule(mod, "glamor_supports_pixmap_import_export");
cf7b2a
     ms->glamor.xv_init = LoaderSymbolFromModule(mod, "glamor_xv_init");
cf7b2a
     ms->glamor.egl_get_driver_name = LoaderSymbolFromModule(mod, "glamor_egl_get_driver_name");
cf7b2a
+
cf7b2a
+    return TRUE;
cf7b2a
 }
cf7b2a
 
cf7b2a
+#endif
cf7b2a
+
cf7b2a
 static void
cf7b2a
 try_enable_glamor(ScrnInfoPtr pScrn)
cf7b2a
 {
cf7b2a
@@ -772,7 +784,6 @@ try_enable_glamor(ScrnInfoPtr pScrn)
cf7b2a
                                                        OPTION_ACCEL_METHOD);
cf7b2a
     Bool do_glamor = (!accel_method_str ||
cf7b2a
                       strcmp(accel_method_str, "glamor") == 0);
cf7b2a
-    void *mod;
cf7b2a
 
cf7b2a
     ms->drmmode.glamor = FALSE;
cf7b2a
 
cf7b2a
@@ -787,9 +798,7 @@ try_enable_glamor(ScrnInfoPtr pScrn)
cf7b2a
         return;
cf7b2a
     }
cf7b2a
 
cf7b2a
-    mod = xf86LoadSubModule(pScrn, GLAMOR_EGL_MODULE_NAME);
cf7b2a
-    if (mod) {
cf7b2a
-        bind_glamor_api(mod, ms);
cf7b2a
+    if (load_glamor(pScrn)) {
cf7b2a
         if (ms->glamor.egl_init(pScrn, ms->fd)) {
cf7b2a
             xf86DrvMsg(pScrn->scrnIndex, X_INFO, "glamor initialized\n");
cf7b2a
             ms->drmmode.glamor = TRUE;
cf7b2a
diff --git a/hw/xfree86/drivers/modesetting/driver.h b/hw/xfree86/drivers/modesetting/driver.h
cf7b2a
index 328a97de1..261f1aac4 100644
cf7b2a
--- a/hw/xfree86/drivers/modesetting/driver.h
cf7b2a
+++ b/hw/xfree86/drivers/modesetting/driver.h
cf7b2a
@@ -132,6 +132,7 @@ typedef struct _modesettingRec {
cf7b2a
         void (*UpdatePacked)(ScreenPtr, shadowBufPtr);
cf7b2a
     } shadow;
cf7b2a
 
cf7b2a
+#ifdef GLAMOR_HAS_GBM
cf7b2a
     /* glamor API */
cf7b2a
     struct {
cf7b2a
         Bool (*back_pixmap_from_fd)(PixmapPtr, int, CARD16, CARD16, CARD16,
cf7b2a
@@ -156,7 +157,7 @@ typedef struct _modesettingRec {
cf7b2a
         XF86VideoAdaptorPtr (*xv_init)(ScreenPtr, int);
cf7b2a
         const char *(*egl_get_driver_name)(ScreenPtr);
cf7b2a
     } glamor;
cf7b2a
-
cf7b2a
+#endif
cf7b2a
 } modesettingRec, *modesettingPtr;
cf7b2a
 
cf7b2a
 #define glamor_finish(screen) ms->glamor.finish(screen)
cf7b2a
-- 
cf7b2a
2.33.1
cf7b2a