|
 |
1b8fcb |
From 18f91b950e22c2a342a4fbc55e9ddf7534a707d2 Mon Sep 17 00:00:00 2001
|
|
|
1b8fcb |
From: Peter Hutterer <peter.hutterer@who-t.net>
|
|
|
1b8fcb |
Date: Wed, 13 Jul 2022 11:23:09 +1000
|
|
|
1b8fcb |
Subject: [PATCH xserver] xkb: fix some possible memleaks in XkbGetKbdByName
|
|
|
1b8fcb |
|
|
|
1b8fcb |
GetComponentByName returns an allocated string, so let's free that if we
|
|
|
1b8fcb |
fail somewhere.
|
|
|
1b8fcb |
|
|
|
1b8fcb |
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
|
1b8fcb |
---
|
|
|
1b8fcb |
xkb/xkb.c | 26 ++++++++++++++++++++------
|
|
|
1b8fcb |
1 file changed, 20 insertions(+), 6 deletions(-)
|
|
|
1b8fcb |
|
|
|
1b8fcb |
diff --git a/xkb/xkb.c b/xkb/xkb.c
|
|
|
1b8fcb |
index 4692895db..b79a269e3 100644
|
|
|
1b8fcb |
--- a/xkb/xkb.c
|
|
|
1b8fcb |
+++ b/xkb/xkb.c
|
|
|
1b8fcb |
@@ -5935,18 +5935,32 @@ ProcXkbGetKbdByName(ClientPtr client)
|
|
|
1b8fcb |
xkb = dev->key->xkbInfo->desc;
|
|
|
1b8fcb |
status = Success;
|
|
|
1b8fcb |
str = (unsigned char *) &stuff[1];
|
|
|
1b8fcb |
- if (GetComponentSpec(&str, TRUE, &status)) /* keymap, unsupported */
|
|
|
1b8fcb |
- return BadMatch;
|
|
|
1b8fcb |
+ {
|
|
|
1b8fcb |
+ char *keymap = GetComponentSpec(&str, TRUE, &status); /* keymap, unsupported */
|
|
|
1b8fcb |
+ if (keymap) {
|
|
|
1b8fcb |
+ free(keymap);
|
|
|
1b8fcb |
+ return BadMatch;
|
|
|
1b8fcb |
+ }
|
|
|
1b8fcb |
+ }
|
|
|
1b8fcb |
names.keycodes = GetComponentSpec(&str, TRUE, &status);
|
|
|
1b8fcb |
names.types = GetComponentSpec(&str, TRUE, &status);
|
|
|
1b8fcb |
names.compat = GetComponentSpec(&str, TRUE, &status);
|
|
|
1b8fcb |
names.symbols = GetComponentSpec(&str, TRUE, &status);
|
|
|
1b8fcb |
names.geometry = GetComponentSpec(&str, TRUE, &status);
|
|
|
1b8fcb |
- if (status != Success)
|
|
|
1b8fcb |
+ if (status == Success) {
|
|
|
1b8fcb |
+ len = str - ((unsigned char *) stuff);
|
|
|
1b8fcb |
+ if ((XkbPaddedSize(len) / 4) != stuff->length)
|
|
|
1b8fcb |
+ status = BadLength;
|
|
|
1b8fcb |
+ }
|
|
|
1b8fcb |
+
|
|
|
1b8fcb |
+ if (status != Success) {
|
|
|
1b8fcb |
+ free(names.keycodes);
|
|
|
1b8fcb |
+ free(names.types);
|
|
|
1b8fcb |
+ free(names.compat);
|
|
|
1b8fcb |
+ free(names.symbols);
|
|
|
1b8fcb |
+ free(names.geometry);
|
|
|
1b8fcb |
return status;
|
|
|
1b8fcb |
- len = str - ((unsigned char *) stuff);
|
|
|
1b8fcb |
- if ((XkbPaddedSize(len) / 4) != stuff->length)
|
|
|
1b8fcb |
- return BadLength;
|
|
|
1b8fcb |
+ }
|
|
|
1b8fcb |
|
|
|
1b8fcb |
CHK_MASK_LEGAL(0x01, stuff->want, XkbGBN_AllComponentsMask);
|
|
|
1b8fcb |
CHK_MASK_LEGAL(0x02, stuff->need, XkbGBN_AllComponentsMask);
|
|
|
1b8fcb |
--
|
|
|
1b8fcb |
2.38.1
|
|
|
1b8fcb |
|