|
 |
88270d |
From f32c851a0ba41f5d8d0f8c869bc394858de721df Mon Sep 17 00:00:00 2001
|
|
|
88270d |
From: =?UTF-8?q?Michel=20D=C3=A4nzer?= <mdaenzer@redhat.com>
|
|
|
88270d |
Date: Thu, 25 Jun 2020 18:09:27 +0200
|
|
|
88270d |
Subject: [PATCH xserver 1/4] present/wnmd: Keep pixmap pointer in
|
|
|
88270d |
present_wnmd_clear_window_flip
|
|
|
88270d |
MIME-Version: 1.0
|
|
|
88270d |
Content-Type: text/plain; charset=UTF-8
|
|
|
88270d |
Content-Transfer-Encoding: 8bit
|
|
|
88270d |
|
|
|
88270d |
The comment was incorrect: Any reference held by the window (see
|
|
|
88270d |
present_wnmd_execute) is in addition to the one in struct present_vblank
|
|
|
88270d |
(see present_vblank_create). So if we don't drop the latter, the pixmap
|
|
|
88270d |
will be leaked.
|
|
|
88270d |
|
|
|
88270d |
Reviewed-by: Dave Airlie <airlied@redhat.com>
|
|
|
88270d |
(cherry picked from commit bc9dd1c71c3722284ffaa7183f4119151b25a44f)
|
|
|
88270d |
Signed-off-by: Michel Dänzer <mdaenzer@redhat.com>
|
|
|
88270d |
---
|
|
|
88270d |
present/present_screen.c | 2 --
|
|
|
88270d |
1 file changed, 2 deletions(-)
|
|
|
88270d |
|
|
|
88270d |
diff --git a/present/present_screen.c b/present/present_screen.c
|
|
|
88270d |
index c7e37c5fd..c435f55f4 100644
|
|
|
88270d |
--- a/present/present_screen.c
|
|
|
88270d |
+++ b/present/present_screen.c
|
|
|
88270d |
@@ -122,8 +122,6 @@ present_wnmd_clear_window_flip(WindowPtr window)
|
|
|
88270d |
|
|
|
88270d |
xorg_list_for_each_entry_safe(vblank, tmp, &window_priv->idle_queue, event_queue) {
|
|
|
88270d |
present_pixmap_idle(vblank->pixmap, vblank->window, vblank->serial, vblank->idle_fence);
|
|
|
88270d |
- /* The pixmap will be destroyed by freeing the window resources. */
|
|
|
88270d |
- vblank->pixmap = NULL;
|
|
|
88270d |
present_vblank_destroy(vblank);
|
|
|
88270d |
}
|
|
|
88270d |
|
|
|
88270d |
--
|
|
|
88270d |
2.26.2
|
|
|
88270d |
|