|
 |
e2b70d |
Please see this bug report for full details:
|
|
|
e2b70d |
https://github.com/lsh123/xmlsec/issues/164
|
|
|
e2b70d |
|
|
|
e2b70d |
commit e303e077fb3e13654ba711b2816ff1a94247338b
|
|
|
e2b70d |
Author: lsh123 <aleksey@aleksey.com>
|
|
|
e2b70d |
Date: Wed Apr 11 17:13:43 2018 -1000
|
|
|
e2b70d |
|
|
|
e2b70d |
Add missing return(-1). (#165)
|
|
|
e2b70d |
|
|
|
e2b70d |
Fixed issue #164. All other crypto libraries are ok.
|
|
|
e2b70d |
|
|
|
e2b70d |
diff --git a/src/openssl/x509.c b/src/openssl/x509.c
|
|
|
e2b70d |
index 15fe70db..b98e62d1 100644
|
|
|
e2b70d |
--- a/src/openssl/x509.c
|
|
|
e2b70d |
+++ b/src/openssl/x509.c
|
|
|
e2b70d |
@@ -870,6 +870,7 @@ xmlSecOpenSSLX509DataNodeRead(xmlSecKeyDataPtr data, xmlNodePtr node, xmlSecKeyI
|
|
|
e2b70d |
xmlSecInternalError2("xmlSecOpenSSLX509CertificateNodeRead",
|
|
|
e2b70d |
xmlSecKeyDataGetName(data),
|
|
|
e2b70d |
"node=%s", xmlSecErrorsSafeString(xmlSecNodeGetName(cur)));
|
|
|
e2b70d |
+ return(-1);
|
|
|
e2b70d |
}
|
|
|
e2b70d |
} else if(xmlSecCheckNodeName(cur, xmlSecNodeX509SubjectName, xmlSecDSigNs)) {
|
|
|
e2b70d |
ret = xmlSecOpenSSLX509SubjectNameNodeRead(data, cur, keyInfoCtx);
|
|
|
e2b70d |
@@ -877,6 +878,7 @@ xmlSecOpenSSLX509DataNodeRead(xmlSecKeyDataPtr data, xmlNodePtr node, xmlSecKeyI
|
|
|
e2b70d |
xmlSecInternalError2("xmlSecOpenSSLX509SubjectNameNodeRead",
|
|
|
e2b70d |
xmlSecKeyDataGetName(data),
|
|
|
e2b70d |
"node=%s", xmlSecErrorsSafeString(xmlSecNodeGetName(cur)));
|
|
|
e2b70d |
+ return(-1);
|
|
|
e2b70d |
}
|
|
|
e2b70d |
} else if(xmlSecCheckNodeName(cur, xmlSecNodeX509IssuerSerial, xmlSecDSigNs)) {
|
|
|
e2b70d |
ret = xmlSecOpenSSLX509IssuerSerialNodeRead(data, cur, keyInfoCtx);
|
|
|
e2b70d |
@@ -884,6 +886,7 @@ xmlSecOpenSSLX509DataNodeRead(xmlSecKeyDataPtr data, xmlNodePtr node, xmlSecKeyI
|
|
|
e2b70d |
xmlSecInternalError2("xmlSecOpenSSLX509IssuerSerialNodeRead",
|
|
|
e2b70d |
xmlSecKeyDataGetName(data),
|
|
|
e2b70d |
"node=%s", xmlSecErrorsSafeString(xmlSecNodeGetName(cur)));
|
|
|
e2b70d |
+ return(-1);
|
|
|
e2b70d |
}
|
|
|
e2b70d |
} else if(xmlSecCheckNodeName(cur, xmlSecNodeX509SKI, xmlSecDSigNs)) {
|
|
|
e2b70d |
ret = xmlSecOpenSSLX509SKINodeRead(data, cur, keyInfoCtx);
|
|
|
e2b70d |
@@ -891,6 +894,7 @@ xmlSecOpenSSLX509DataNodeRead(xmlSecKeyDataPtr data, xmlNodePtr node, xmlSecKeyI
|
|
|
e2b70d |
xmlSecInternalError2("xmlSecOpenSSLX509SKINodeRead",
|
|
|
e2b70d |
xmlSecKeyDataGetName(data),
|
|
|
e2b70d |
"node=%s", xmlSecErrorsSafeString(xmlSecNodeGetName(cur)));
|
|
|
e2b70d |
+ return(-1);
|
|
|
e2b70d |
}
|
|
|
e2b70d |
} else if(xmlSecCheckNodeName(cur, xmlSecNodeX509CRL, xmlSecDSigNs)) {
|
|
|
e2b70d |
ret = xmlSecOpenSSLX509CRLNodeRead(data, cur, keyInfoCtx);
|
|
|
e2b70d |
@@ -898,6 +902,7 @@ xmlSecOpenSSLX509DataNodeRead(xmlSecKeyDataPtr data, xmlNodePtr node, xmlSecKeyI
|
|
|
e2b70d |
xmlSecInternalError2("xmlSecOpenSSLX509CRLNodeRead",
|
|
|
e2b70d |
xmlSecKeyDataGetName(data),
|
|
|
e2b70d |
"node=%s", xmlSecErrorsSafeString(xmlSecNodeGetName(cur)));
|
|
|
e2b70d |
+ return(-1);
|
|
|
e2b70d |
}
|
|
|
e2b70d |
} else if((keyInfoCtx->flags & XMLSEC_KEYINFO_FLAGS_X509DATA_STOP_ON_UNKNOWN_CHILD) != 0) {
|
|
|
e2b70d |
/* laxi schema validation: ignore unknown nodes */
|