|
 |
5d5cbe |
From 62c713cb0c7791717c0b2a663ff0cc72842fe6c7 Mon Sep 17 00:00:00 2001
|
|
|
5d5cbe |
From: "Darrick J. Wong" <darrick.wong@oracle.com>
|
|
|
5d5cbe |
Date: Fri, 20 Nov 2020 17:03:27 -0500
|
|
|
5d5cbe |
Subject: [PATCH] xfs_repair: check inode btree block counters in AGI
|
|
|
5d5cbe |
|
|
|
5d5cbe |
Make sure that both inode btree block counters in the AGI are correct.
|
|
|
5d5cbe |
|
|
|
5d5cbe |
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
|
|
|
5d5cbe |
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
|
|
|
5d5cbe |
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
|
|
|
5d5cbe |
---
|
|
|
5d5cbe |
|
|
|
5d5cbe |
diff --git a/repair/scan.c b/repair/scan.c
|
|
|
5d5cbe |
index 5b76212..086a3cd 100644
|
|
|
5d5cbe |
--- a/repair/scan.c
|
|
|
5d5cbe |
+++ b/repair/scan.c
|
|
|
5d5cbe |
@@ -1933,6 +1933,12 @@ _("invalid inode count, inode chunk %d/%u, count %d ninodes %d\n"),
|
|
|
5d5cbe |
return suspect;
|
|
|
5d5cbe |
}
|
|
|
5d5cbe |
|
|
|
5d5cbe |
+struct ino_priv {
|
|
|
5d5cbe |
+ struct aghdr_cnts *agcnts;
|
|
|
5d5cbe |
+ uint32_t ino_blocks;
|
|
|
5d5cbe |
+ uint32_t fino_blocks;
|
|
|
5d5cbe |
+};
|
|
|
5d5cbe |
+
|
|
|
5d5cbe |
/*
|
|
|
5d5cbe |
* this one walks the inode btrees sucking the info there into
|
|
|
5d5cbe |
* the incore avl tree. We try and rescue corrupted btree records
|
|
|
5d5cbe |
@@ -1961,7 +1967,8 @@ scan_inobt(
|
|
|
5d5cbe |
void *priv,
|
|
|
5d5cbe |
const struct xfs_buf_ops *ops)
|
|
|
5d5cbe |
{
|
|
|
5d5cbe |
- struct aghdr_cnts *agcnts = priv;
|
|
|
5d5cbe |
+ struct ino_priv *ipriv = priv;
|
|
|
5d5cbe |
+ struct aghdr_cnts *agcnts = ipriv->agcnts;
|
|
|
5d5cbe |
char *name;
|
|
|
5d5cbe |
int i;
|
|
|
5d5cbe |
int numrecs;
|
|
|
5d5cbe |
@@ -1977,10 +1984,12 @@ scan_inobt(
|
|
|
5d5cbe |
case XFS_FIBT_MAGIC:
|
|
|
5d5cbe |
case XFS_FIBT_CRC_MAGIC:
|
|
|
5d5cbe |
name = "fino";
|
|
|
5d5cbe |
+ ipriv->fino_blocks++;
|
|
|
5d5cbe |
break;
|
|
|
5d5cbe |
case XFS_IBT_MAGIC:
|
|
|
5d5cbe |
case XFS_IBT_CRC_MAGIC:
|
|
|
5d5cbe |
name = "ino";
|
|
|
5d5cbe |
+ ipriv->ino_blocks++;
|
|
|
5d5cbe |
break;
|
|
|
5d5cbe |
default:
|
|
|
5d5cbe |
name = "(unknown)";
|
|
|
5d5cbe |
@@ -2320,6 +2329,9 @@ validate_agi(
|
|
|
5d5cbe |
xfs_agnumber_t agno,
|
|
|
5d5cbe |
struct aghdr_cnts *agcnts)
|
|
|
5d5cbe |
{
|
|
|
5d5cbe |
+ struct ino_priv priv = {
|
|
|
5d5cbe |
+ .agcnts = agcnts,
|
|
|
5d5cbe |
+ };
|
|
|
5d5cbe |
xfs_agblock_t bno;
|
|
|
5d5cbe |
int i;
|
|
|
5d5cbe |
uint32_t magic;
|
|
|
5d5cbe |
@@ -2329,7 +2341,7 @@ validate_agi(
|
|
|
5d5cbe |
magic = xfs_sb_version_hascrc(&mp->m_sb) ? XFS_IBT_CRC_MAGIC
|
|
|
5d5cbe |
: XFS_IBT_MAGIC;
|
|
|
5d5cbe |
scan_sbtree(bno, be32_to_cpu(agi->agi_level),
|
|
|
5d5cbe |
- agno, 0, scan_inobt, 1, magic, agcnts,
|
|
|
5d5cbe |
+ agno, 0, scan_inobt, 1, magic, &priv,
|
|
|
5d5cbe |
&xfs_inobt_buf_ops);
|
|
|
5d5cbe |
} else {
|
|
|
5d5cbe |
do_warn(_("bad agbno %u for inobt root, agno %d\n"),
|
|
|
5d5cbe |
@@ -2342,7 +2354,7 @@ validate_agi(
|
|
|
5d5cbe |
magic = xfs_sb_version_hascrc(&mp->m_sb) ?
|
|
|
5d5cbe |
XFS_FIBT_CRC_MAGIC : XFS_FIBT_MAGIC;
|
|
|
5d5cbe |
scan_sbtree(bno, be32_to_cpu(agi->agi_free_level),
|
|
|
5d5cbe |
- agno, 0, scan_inobt, 1, magic, agcnts,
|
|
|
5d5cbe |
+ agno, 0, scan_inobt, 1, magic, &priv,
|
|
|
5d5cbe |
&xfs_inobt_buf_ops);
|
|
|
5d5cbe |
} else {
|
|
|
5d5cbe |
do_warn(_("bad agbno %u for finobt root, agno %d\n"),
|
|
|
5d5cbe |
@@ -2350,6 +2362,17 @@ validate_agi(
|
|
|
5d5cbe |
}
|
|
|
5d5cbe |
}
|
|
|
5d5cbe |
|
|
|
5d5cbe |
+ if (xfs_sb_version_hasinobtcounts(&mp->m_sb)) {
|
|
|
5d5cbe |
+ if (be32_to_cpu(agi->agi_iblocks) != priv.ino_blocks)
|
|
|
5d5cbe |
+ do_warn(_("bad inobt block count %u, saw %u\n"),
|
|
|
5d5cbe |
+ be32_to_cpu(agi->agi_iblocks),
|
|
|
5d5cbe |
+ priv.ino_blocks);
|
|
|
5d5cbe |
+ if (be32_to_cpu(agi->agi_fblocks) != priv.fino_blocks)
|
|
|
5d5cbe |
+ do_warn(_("bad finobt block count %u, saw %u\n"),
|
|
|
5d5cbe |
+ be32_to_cpu(agi->agi_fblocks),
|
|
|
5d5cbe |
+ priv.fino_blocks);
|
|
|
5d5cbe |
+ }
|
|
|
5d5cbe |
+
|
|
|
5d5cbe |
if (be32_to_cpu(agi->agi_count) != agcnts->agicount) {
|
|
|
5d5cbe |
do_warn(_("agi_count %u, counted %u in ag %u\n"),
|
|
|
5d5cbe |
be32_to_cpu(agi->agi_count), agcnts->agicount, agno);
|