|
 |
8f4474 |
From d89edb6112f54fb65036c31eba291bda5fcad2b3 Mon Sep 17 00:00:00 2001
|
|
|
8f4474 |
Message-Id: <d89edb6112f54fb65036c31eba291bda5fcad2b3.1522770749.git.davide.caratti@gmail.com>
|
|
|
8f4474 |
From: Davide Caratti <davide.caratti@gmail.com>
|
|
|
8f4474 |
Date: Wed, 28 Mar 2018 16:34:56 +0200
|
|
|
8f4474 |
Subject: [PATCH] wpa_supplicant: Don't reply to EAPOL if pkt_type is
|
|
|
8f4474 |
PACKET_OTHERHOST
|
|
|
8f4474 |
|
|
|
8f4474 |
When wpa_supplicant is running on a Linux interface that is configured in
|
|
|
8f4474 |
promiscuous mode, and it is not a member of a bridge, incoming EAPOL
|
|
|
8f4474 |
packets are processed regardless of the Destination Address in the frame.
|
|
|
8f4474 |
As a consequence, there are situations where wpa_supplicant replies to
|
|
|
8f4474 |
EAPOL packets that are not destined for it.
|
|
|
8f4474 |
|
|
|
8f4474 |
This behavior seems undesired (see IEEE Std 802.1X-2010, 11.4.a), and can
|
|
|
8f4474 |
be avoided by attaching a BPF filter that lets the kernel discard packets
|
|
|
8f4474 |
having pkt_type equal to PACKET_OTHERHOST.
|
|
|
8f4474 |
|
|
|
8f4474 |
Signed-off-by: Davide Caratti <davide.caratti@gmail.com>
|
|
|
8f4474 |
---
|
|
|
8f4474 |
src/l2_packet/l2_packet.h | 1 +
|
|
|
8f4474 |
src/l2_packet/l2_packet_linux.c | 23 +++++++++++++++++++++++
|
|
|
8f4474 |
wpa_supplicant/wpa_supplicant.c | 5 +++++
|
|
|
8f4474 |
3 files changed, 29 insertions(+)
|
|
|
8f4474 |
|
|
|
8f4474 |
diff --git a/src/l2_packet/l2_packet.h b/src/l2_packet/l2_packet.h
|
|
|
8f4474 |
index 2a4524582..53871774b 100644
|
|
|
8f4474 |
--- a/src/l2_packet/l2_packet.h
|
|
|
8f4474 |
+++ b/src/l2_packet/l2_packet.h
|
|
|
8f4474 |
@@ -42,6 +42,7 @@ struct l2_ethhdr {
|
|
|
8f4474 |
enum l2_packet_filter_type {
|
|
|
8f4474 |
L2_PACKET_FILTER_DHCP,
|
|
|
8f4474 |
L2_PACKET_FILTER_NDISC,
|
|
|
8f4474 |
+ L2_PACKET_FILTER_PKTTYPE,
|
|
|
8f4474 |
};
|
|
|
8f4474 |
|
|
|
8f4474 |
/**
|
|
|
8f4474 |
diff --git a/src/l2_packet/l2_packet_linux.c b/src/l2_packet/l2_packet_linux.c
|
|
|
8f4474 |
index 65b490679..291c9dd26 100644
|
|
|
8f4474 |
--- a/src/l2_packet/l2_packet_linux.c
|
|
|
8f4474 |
+++ b/src/l2_packet/l2_packet_linux.c
|
|
|
8f4474 |
@@ -84,6 +84,26 @@ static const struct sock_fprog ndisc_sock_filter = {
|
|
|
8f4474 |
.filter = ndisc_sock_filter_insns,
|
|
|
8f4474 |
};
|
|
|
8f4474 |
|
|
|
8f4474 |
+/* drop packet if skb->pkt_type is PACKET_OTHERHOST (0x03). Generated by:
|
|
|
8f4474 |
+ * $ bpfc - <
|
|
|
8f4474 |
+ * > ldb #type
|
|
|
8f4474 |
+ * > jeq #0x03, drop
|
|
|
8f4474 |
+ * > pass: ret #-1
|
|
|
8f4474 |
+ * > drop: ret #0
|
|
|
8f4474 |
+ * > EOF
|
|
|
8f4474 |
+ */
|
|
|
8f4474 |
+static struct sock_filter pkt_type_filter_insns[] = {
|
|
|
8f4474 |
+ { 0x30, 0, 0, 0xfffff004 },
|
|
|
8f4474 |
+ { 0x15, 1, 0, 0x00000003 },
|
|
|
8f4474 |
+ { 0x6, 0, 0, 0xffffffff },
|
|
|
8f4474 |
+ { 0x6, 0, 0, 0x00000000 },
|
|
|
8f4474 |
+};
|
|
|
8f4474 |
+
|
|
|
8f4474 |
+static const struct sock_fprog pkt_type_sock_filter = {
|
|
|
8f4474 |
+ .len = ARRAY_SIZE(pkt_type_filter_insns),
|
|
|
8f4474 |
+ .filter = pkt_type_filter_insns,
|
|
|
8f4474 |
+};
|
|
|
8f4474 |
+
|
|
|
8f4474 |
|
|
|
8f4474 |
int l2_packet_get_own_addr(struct l2_packet_data *l2, u8 *addr)
|
|
|
8f4474 |
{
|
|
|
8f4474 |
@@ -471,6 +491,9 @@ int l2_packet_set_packet_filter(struct l2_packet_data *l2,
|
|
|
8f4474 |
case L2_PACKET_FILTER_NDISC:
|
|
|
8f4474 |
sock_filter = &ndisc_sock_filter;
|
|
|
8f4474 |
break;
|
|
|
8f4474 |
+ case L2_PACKET_FILTER_PKTTYPE:
|
|
|
8f4474 |
+ sock_filter = &pkt_type_sock_filter;
|
|
|
8f4474 |
+ break;
|
|
|
8f4474 |
default:
|
|
|
8f4474 |
return -1;
|
|
|
8f4474 |
}
|
|
|
8f4474 |
diff --git a/wpa_supplicant/wpa_supplicant.c b/wpa_supplicant/wpa_supplicant.c
|
|
|
8f4474 |
index 2a05ef910..dcec68a03 100644
|
|
|
8f4474 |
--- a/wpa_supplicant/wpa_supplicant.c
|
|
|
8f4474 |
+++ b/wpa_supplicant/wpa_supplicant.c
|
|
|
8f4474 |
@@ -4014,6 +4014,11 @@ int wpa_supplicant_update_mac_addr(struct wpa_supplicant *wpa_s)
|
|
|
8f4474 |
wpa_supplicant_rx_eapol, wpa_s, 0);
|
|
|
8f4474 |
if (wpa_s->l2 == NULL)
|
|
|
8f4474 |
return -1;
|
|
|
8f4474 |
+
|
|
|
8f4474 |
+ if (l2_packet_set_packet_filter(wpa_s->l2,
|
|
|
8f4474 |
+ L2_PACKET_FILTER_PKTTYPE))
|
|
|
8f4474 |
+ wpa_dbg(wpa_s, MSG_DEBUG,
|
|
|
8f4474 |
+ "Failed to attach pkt_type filter");
|
|
|
8f4474 |
} else {
|
|
|
8f4474 |
const u8 *addr = wpa_drv_get_mac_addr(wpa_s);
|
|
|
8f4474 |
if (addr)
|
|
|
8f4474 |
--
|
|
|
8f4474 |
2.14.3
|
|
|
8f4474 |
|