|
 |
41389a |
From 37e9f511eb0072dbce190cb21e2d48f022173b03 Mon Sep 17 00:00:00 2001
|
|
|
41389a |
Message-Id: <37e9f511eb0072dbce190cb21e2d48f022173b03.1488376602.git.dcaratti@redhat.com>
|
|
|
41389a |
From: Badrish Adiga H R <badrish.adigahr@gmail.com>
|
|
|
41389a |
Date: Tue, 7 Feb 2017 14:28:31 +0530
|
|
|
41389a |
Subject: [PATCH] mka: Send MKPDUs forever if mode is PSK
|
|
|
41389a |
|
|
|
41389a |
Issue: When 2 peers are running MACsec in PSK mode with CA
|
|
|
41389a |
established, if the interface goes down and comes up after
|
|
|
41389a |
time > 10 seconds, CA does not get re-established.
|
|
|
41389a |
|
|
|
41389a |
Root cause: This is because retry_count of both the peers
|
|
|
41389a |
would have reached MAX_RETRY_CNT and stays idle for other to
|
|
|
41389a |
respond. This is clear deadlock situation where peer A waits
|
|
|
41389a |
for MKA packets from peer B to wake up and vice-versa.
|
|
|
41389a |
|
|
|
41389a |
Fix: If MACsec is running in PSK mode, we should send MKPDUs
|
|
|
41389a |
forever for every 2 seconds.
|
|
|
41389a |
|
|
|
41389a |
Signed-off-by: Badrish Adiga H R <badrish.adigahr@gmail.com>
|
|
|
41389a |
---
|
|
|
41389a |
src/pae/ieee802_1x_kay.c | 6 ++++--
|
|
|
41389a |
src/pae/ieee802_1x_kay_i.h | 1 +
|
|
|
41389a |
2 files changed, 5 insertions(+), 2 deletions(-)
|
|
|
41389a |
|
|
|
41389a |
diff --git a/src/pae/ieee802_1x_kay.c b/src/pae/ieee802_1x_kay.c
|
|
|
41389a |
index 92fd7ba..e420fc1 100644
|
|
|
41389a |
--- a/src/pae/ieee802_1x_kay.c
|
|
|
41389a |
+++ b/src/pae/ieee802_1x_kay.c
|
|
|
41389a |
@@ -2428,7 +2428,8 @@ static void ieee802_1x_participant_timer(void *eloop_ctx, void *timeout_ctx)
|
|
|
41389a |
participant->new_sak = FALSE;
|
|
|
41389a |
}
|
|
|
41389a |
|
|
|
41389a |
- if (participant->retry_count < MAX_RETRY_CNT) {
|
|
|
41389a |
+ if (participant->retry_count < MAX_RETRY_CNT ||
|
|
|
41389a |
+ participant->mode == PSK) {
|
|
|
41389a |
ieee802_1x_participant_send_mkpdu(participant);
|
|
|
41389a |
participant->retry_count++;
|
|
|
41389a |
}
|
|
|
41389a |
@@ -2828,7 +2829,7 @@ int ieee802_1x_kay_enable_new_info(struct ieee802_1x_kay *kay)
|
|
|
41389a |
if (!principal)
|
|
|
41389a |
return -1;
|
|
|
41389a |
|
|
|
41389a |
- if (principal->retry_count < MAX_RETRY_CNT) {
|
|
|
41389a |
+ if (principal->retry_count < MAX_RETRY_CNT || principal->mode == PSK) {
|
|
|
41389a |
ieee802_1x_participant_send_mkpdu(principal);
|
|
|
41389a |
principal->retry_count++;
|
|
|
41389a |
}
|
|
|
41389a |
@@ -3368,6 +3369,7 @@ ieee802_1x_kay_create_mka(struct ieee802_1x_kay *kay, struct mka_key_name *ckn,
|
|
|
41389a |
participant->mka_life = MKA_LIFE_TIME / 1000 + time(NULL) +
|
|
|
41389a |
usecs / 1000000;
|
|
|
41389a |
}
|
|
|
41389a |
+ participant->mode = mode;
|
|
|
41389a |
|
|
|
41389a |
return participant;
|
|
|
41389a |
|
|
|
41389a |
diff --git a/src/pae/ieee802_1x_kay_i.h b/src/pae/ieee802_1x_kay_i.h
|
|
|
41389a |
index 0c4bb8e..bc522d8 100644
|
|
|
41389a |
--- a/src/pae/ieee802_1x_kay_i.h
|
|
|
41389a |
+++ b/src/pae/ieee802_1x_kay_i.h
|
|
|
41389a |
@@ -93,6 +93,7 @@ struct ieee802_1x_mka_participant {
|
|
|
41389a |
Boolean active;
|
|
|
41389a |
Boolean participant;
|
|
|
41389a |
Boolean retain;
|
|
|
41389a |
+ enum mka_created_mode mode;
|
|
|
41389a |
|
|
|
41389a |
enum { DEFAULT, DISABLED, ON_OPER_UP, ALWAYS } activate;
|
|
|
41389a |
|
|
|
41389a |
--
|
|
|
41389a |
2.7.4
|
|
|
41389a |
|