Blame SOURCES/wireshark-0024-covscan.patch

0de736
diff --git a/tshark.c b/tshark.c
0de736
index 00c28db781..e02b61b663 100644
0de736
--- a/tshark.c
0de736
+++ b/tshark.c
0de736
@@ -1977,10 +1977,10 @@ real_main(int argc, char *argv[])
0de736
       /* Activate the export PDU tap */
0de736
       comment = g_strdup_printf("Dump of PDUs from %s", cf_name);
0de736
       err = exp_pdu_open(&exp_pdu_tap_data, exp_fd, comment);
0de736
+      g_free(comment);
0de736
       if (err != 0) {
0de736
           cfile_dump_open_failure_message("TShark", exp_pdu_filename, err,
0de736
                                           WTAP_FILE_TYPE_SUBTYPE_PCAPNG);
0de736
-          g_free(comment);
0de736
           exit_status = INVALID_EXPORT;
0de736
           goto clean_exit;
0de736
       }
0de736
diff --git a/ui/export_pdu_ui_utils.c b/ui/export_pdu_ui_utils.c
0de736
index a567a61991..c9e40b7a24 100644
0de736
--- a/ui/export_pdu_ui_utils.c
0de736
+++ b/ui/export_pdu_ui_utils.c
0de736
@@ -43,8 +43,8 @@ exp_pdu_file_open(exp_pdu_t *exp_pdu_tap_data)
0de736
 
0de736
     comment = g_strdup_printf("Dump of PDUs from %s", cfile.filename);
0de736
     err = exp_pdu_open(exp_pdu_tap_data, import_file_fd, comment);
0de736
+    g_free(comment);
0de736
     if (err != 0) {
0de736
-        g_free(comment);
0de736
         cfile_dump_open_failure_alert_box(capfile_name ? capfile_name : "temporary file",
0de736
                                           err, WTAP_FILE_TYPE_SUBTYPE_PCAPNG);
0de736
         goto end;
0de736
diff --git a/ui/tap_export_pdu.c b/ui/tap_export_pdu.c
0de736
index 25232f0452..d3302a5aca 100644
0de736
--- a/ui/tap_export_pdu.c
0de736
+++ b/ui/tap_export_pdu.c
0de736
@@ -82,7 +82,7 @@ export_pdu_packet(void *tapdata, packet_info *pinfo, epan_dissect_t *edt, const
0de736
 }
0de736
 
0de736
 int
0de736
-exp_pdu_open(exp_pdu_t *exp_pdu_tap_data, int fd, char *comment)
0de736
+exp_pdu_open(exp_pdu_t *exp_pdu_tap_data, int fd, const char *comment)
0de736
 {
0de736
 
0de736
     int   err;
0de736
@@ -103,7 +103,6 @@ exp_pdu_open(exp_pdu_t *exp_pdu_tap_data, int fd, char *comment)
0de736
 
0de736
     /* options */
0de736
     wtap_block_add_string_option(shb_hdr, OPT_COMMENT, comment, strlen(comment));
0de736
-    g_free(comment);
0de736
 
0de736
     /*
0de736
      * UTF-8 string containing the name of the operating system used to create
0de736
diff --git a/ui/tap_export_pdu.h b/ui/tap_export_pdu.h
0de736
index ea5c4077e1..9ae2dea65f 100644
0de736
--- a/ui/tap_export_pdu.h
0de736
+++ b/ui/tap_export_pdu.h
0de736
@@ -41,7 +41,7 @@ char *exp_pdu_pre_open(const char *tap_name, const char *filter,
0de736
 *
0de736
 * @return 0 on success or a wtap error code.
0de736
 */
0de736
-int exp_pdu_open(exp_pdu_t *data, int fd, char *comment);
0de736
+int exp_pdu_open(exp_pdu_t *data, int fd, const char *comment);
0de736
 
0de736
 /* Stops the PDUs export. */
0de736
 int exp_pdu_close(exp_pdu_t *exp_pdu_tap_data);
0de736
diff --git a/ui/cli/tap-wspstat.c b/ui/cli/tap-wspstat.c
0de736
index 22862cdaf8..fd6f3ad427 100644
0de736
--- a/ui/cli/tap-wspstat.c
0de736
+++ b/ui/cli/tap-wspstat.c
0de736
@@ -252,9 +252,9 @@ wspstat_init(const char *opt_arg, void *userdata _U_)
0de736
 		/* error, we failed to attach to the tap. clean up */
0de736
 		g_free(sp->pdu_stats);
0de736
 		g_free(sp->filter);
0de736
-		g_free(sp);
0de736
 		g_hash_table_foreach( sp->hash, (GHFunc) wsp_free_hash_table, NULL ) ;
0de736
 		g_hash_table_destroy( sp->hash );
0de736
+		g_free(sp);
0de736
 		fprintf(stderr, "tshark: Couldn't register wsp,stat tap: %s\n",
0de736
 				error_string->str);
0de736
 		g_string_free(error_string, TRUE);
0de736
diff --git a/epan/dissectors/packet-isobus-vt.c b/epan/dissectors/packet-isobus-vt.c
0de736
index 1f9fa98..79f1c1f 100644
0de736
--- a/epan/dissectors/packet-isobus-vt.c
0de736
+++ b/epan/dissectors/packet-isobus-vt.c
0de736
@@ -1546,16 +1546,8 @@ dissect_vt(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, enum vt_directio
0de736
             }
0de736
             else
0de736
             {
0de736
-                if(status == 0)
0de736
-                {
0de736
-                    col_append_fstr(pinfo->cinfo, COL_INFO, "Status of Auxiliary Input %s was successfully changed to enabled",
0de736
-                        get_object_id_string(auxiliary_input_object_id));
0de736
-                }
0de736
-                else
0de736
-                {
0de736
-                    col_append_fstr(pinfo->cinfo, COL_INFO, "Status of Auxiliary Input %s was successfully changed to enabled",
0de736
-                        get_object_id_string(auxiliary_input_object_id));
0de736
-                }
0de736
+                col_append_fstr(pinfo->cinfo, COL_INFO, "Status of Auxiliary Input %s was successfully changed to enabled",
0de736
+                    get_object_id_string(auxiliary_input_object_id));
0de736
             }
0de736
         }
0de736
     }
0de736
diff --git a/epan/dfilter/dfilter.c b/epan/dfilter/dfilter.c
0de736
index a975f84..3e440b3 100644
0de736
--- a/epan/dfilter/dfilter.c
0de736
+++ b/epan/dfilter/dfilter.c
0de736
@@ -221,6 +221,7 @@ dfilter_compile(const gchar *text, dfilter_t **dfp, gchar **err_msg)
0de736
 	}
0de736
 
0de736
 	if ( !( expanded_text = dfilter_macro_apply(text, err_msg) ) ) {
0de736
+		*dfp = NULL;
0de736
 		return FALSE;
0de736
 	}
0de736