164878
From 8dfaa8fa7c97cd1372a0a233b83fbc7945447b75 Mon Sep 17 00:00:00 2001
164878
From: Uli Heilmeier <uh@heilmeier.eu>
164878
Date: Fri, 05 Oct 2018 08:54:55 +0200
164878
Subject: [PATCH] *shark: Update help and manpage for name resolving
164878
164878
Add 'v' option for VLAN ID resolving and get rid of
164878
deprecated 'C' option.
164878
164878
Bug: 14826
164878
Change-Id: I63104f4a465d251048693ad02882ea7eb2c4d926
164878
Reviewed-on: https://code.wireshark.org/review/30029
164878
Petri-Dish: Anders Broman <a.broman58@gmail.com>
164878
Tested-by: Petri Dish Buildbot
164878
Reviewed-by: Anders Broman <a.broman58@gmail.com>
164878
---
164878
164878
diff --git a/doc/rawshark.pod b/doc/rawshark.pod
164878
index be6caee..8f10445 100644
164878
--- a/doc/rawshark.pod
164878
+++ b/doc/rawshark.pod
164878
@@ -183,6 +183,8 @@
164878
 
164878
 B<d> to enable resolution from captured DNS packets
164878
 
164878
+B<v> to enable VLAN IDs to names resolution
164878
+
164878
 =item -o  E<lt>preferenceE<gt>:E<lt>valueE<gt>
164878
 
164878
 Set a preference value, overriding the default value and any value read
164878
diff --git a/doc/tshark.pod b/doc/tshark.pod
164878
index 263332b..8aff736 100644
164878
--- a/doc/tshark.pod
164878
+++ b/doc/tshark.pod
164878
@@ -676,6 +676,8 @@
164878
 
164878
 B<t> to enable transport-layer port number resolution
164878
 
164878
+B<v> to enable VLAN IDs to names resolution
164878
+
164878
 =item -o  E<lt>preferenceE<gt>:E<lt>valueE<gt>
164878
 
164878
 Set a preference value, overriding the default value and any value read
164878
diff --git a/doc/wireshark.pod.template b/doc/wireshark.pod.template
164878
index a25ea65..c45581f 100644
164878
--- a/doc/wireshark.pod.template
164878
+++ b/doc/wireshark.pod.template
164878
@@ -499,6 +499,8 @@
164878
 
164878
 B<d> to enable resolution from captured DNS packets
164878
 
164878
+B<v> to enable VLAN IDs to names resolution
164878
+
164878
 =item -o  E<lt>preference/recent settingE<gt>
164878
 
164878
 Set a preference or recent value, overriding the default value and any value
164878
diff --git a/docbook/wsug_src/WSUG_chapter_customize.asciidoc b/docbook/wsug_src/WSUG_chapter_customize.asciidoc
164878
index 67afafc..a7411c4 100644
164878
--- a/docbook/wsug_src/WSUG_chapter_customize.asciidoc
164878
+++ b/docbook/wsug_src/WSUG_chapter_customize.asciidoc
164878
@@ -76,7 +76,7 @@
164878
 Processing:
164878
   -R <read filter>         packet filter in Wireshark display filter syntax
164878
   -n                       disable all name resolutions (def: all enabled)
164878
-  -N <name resolve flags>  enable specific name resolution(s): "mnNtCd"
164878
+  -N <name resolve flags>  enable specific name resolution(s): "mnNtdv"
164878
   -d <layer_type>==<selector>,<decode_as_protocol> ...
164878
                            "Decode As”, see the man page for details
164878
                            Example: tcp.port==8888,http
164878
@@ -295,6 +295,7 @@
164878
 resolution, `n` to enable network address resolution, and `t` to enable
164878
 transport-layer port number resolution. This overrides `-n` if both `-N` and
164878
 `-n` are present. The letter `d` enables resolution from captured DNS packets.
164878
+The letter `v` enables resolution from VLAN IDs to names.
164878
 
164878
 -o <preference or recent settings>::
164878
 
164878
diff --git a/docbook/wsug_src/rawshark-h.txt b/docbook/wsug_src/rawshark-h.txt
164878
index 39aeec0..7de64ec 100644
164878
--- a/docbook/wsug_src/rawshark-h.txt
164878
+++ b/docbook/wsug_src/rawshark-h.txt
164878
@@ -13,7 +13,7 @@
164878
   -F <field>               field to display
164878
   -m                       virtual memory limit, in bytes
164878
   -n                       disable all name resolution (def: all enabled)
164878
-  -N <name resolve flags>  enable specific name resolution(s): "mnNtd"
164878
+  -N <name resolve flags>  enable specific name resolution(s): "mnNtdv"
164878
   -p                       use the system's packet header format
164878
                            (which may have 64-bit timestamps)
164878
   -R <read filter>         packet filter in Wireshark display filter syntax
164878
diff --git a/docbook/wsug_src/tshark-h.txt b/docbook/wsug_src/tshark-h.txt
164878
index 9eaccda..ffe12b9 100644
164878
--- a/docbook/wsug_src/tshark-h.txt
164878
+++ b/docbook/wsug_src/tshark-h.txt
164878
@@ -38,7 +38,7 @@
164878
   -Y <display filter>      packet displaY filter in Wireshark display filter
164878
                            syntax
164878
   -n                       disable all name resolutions (def: all enabled)
164878
-  -N <name resolve flags>  enable specific name resolution(s): "mnNtCd"
164878
+  -N <name resolve flags>  enable specific name resolution(s): "mnNtdv"
164878
   -d <layer_type>==<selector>,<decode_as_protocol> ...
164878
                            "Decode As", see the man page for details
164878
                            Example: tcp.port==8888,http
164878
diff --git a/epan/prefs.c b/epan/prefs.c
164878
index 34c05d3..d732eb2 100644
164878
--- a/epan/prefs.c
164878
+++ b/epan/prefs.c
164878
@@ -4932,10 +4932,6 @@
164878
         case 't':
164878
             name_resolve->transport_name = TRUE;
164878
             break;
164878
-        case 'C':
164878
-            /* DEPRECATED */
164878
-            /* name_resolve->concurrent_dns */
164878
-            break;
164878
         case 'd':
164878
             name_resolve->dns_pkt_addr_resolution = TRUE;
164878
             break;
164878
diff --git a/rawshark.c b/rawshark.c
164878
index 61875c1..29cb2ba 100644
164878
--- a/rawshark.c
164878
+++ b/rawshark.c
164878
@@ -190,7 +190,7 @@
164878
     fprintf(output, "  -m                       virtual memory limit, in bytes\n");
164878
 #endif
164878
     fprintf(output, "  -n                       disable all name resolution (def: all enabled)\n");
164878
-    fprintf(output, "  -N <name resolve flags>  enable specific name resolution(s): \"mnNtd\"\n");
164878
+    fprintf(output, "  -N <name resolve flags>  enable specific name resolution(s): \"mnNtdv\"\n");
164878
     fprintf(output, "  -p                       use the system's packet header format\n");
164878
     fprintf(output, "                           (which may have 64-bit timestamps)\n");
164878
     fprintf(output, "  -R <read filter>         packet filter in Wireshark display filter syntax\n");
164878
diff --git a/tshark.c b/tshark.c
164878
index a152c2b..2d84153 100644
164878
--- a/tshark.c
164878
+++ b/tshark.c
164878
@@ -370,7 +370,7 @@
164878
   fprintf(output, "  -Y <display filter>      packet displaY filter in Wireshark display filter\n");
164878
   fprintf(output, "                           syntax\n");
164878
   fprintf(output, "  -n                       disable all name resolutions (def: all enabled)\n");
164878
-  fprintf(output, "  -N <name resolve flags>  enable specific name resolution(s): \"mnNtCd\"\n");
164878
+  fprintf(output, "  -N <name resolve flags>  enable specific name resolution(s): \"mnNtdv\"\n");
164878
   fprintf(output, "  -d %s ...\n", DECODE_AS_ARG_TEMPLATE);
164878
   fprintf(output, "                           \"Decode As\", see the man page for details\n");
164878
   fprintf(output, "                           Example: tcp.port==8888,http\n");
164878
diff --git a/ui/commandline.c b/ui/commandline.c
164878
index 6a26be3..7c0768a 100644
164878
--- a/ui/commandline.c
164878
+++ b/ui/commandline.c
164878
@@ -123,7 +123,7 @@
164878
     fprintf(output, "Processing:\n");
164878
     fprintf(output, "  -R <read filter>         packet filter in Wireshark display filter syntax\n");
164878
     fprintf(output, "  -n                       disable all name resolutions (def: all enabled)\n");
164878
-    fprintf(output, "  -N <name resolve flags>  enable specific name resolution(s): \"mnNtd\"\n");
164878
+    fprintf(output, "  -N <name resolve flags>  enable specific name resolution(s): \"mnNtdv\"\n");
164878
     fprintf(output, "  -d %s ...\n", DECODE_AS_ARG_TEMPLATE);
164878
     fprintf(output, "                           \"Decode As\", see the man page for details\n");
164878
     fprintf(output, "                           Example: tcp.port==8888,http\n");
164878
diff --git a/ui/dissect_opts.c b/ui/dissect_opts.c
164878
index 77e7b58..c6aa771 100644
164878
--- a/ui/dissect_opts.c
164878
+++ b/ui/dissect_opts.c
164878
@@ -79,7 +79,8 @@
164878
                             "\t'n' to enable network address resolution\n"
164878
                             "\t'N' to enable using external resolvers (e.g., DNS)\n"
164878
                             "\t    for network address resolution\n"
164878
-                            "\t't' to enable transport-layer port number resolution");
164878
+                            "\t't' to enable transport-layer port number resolution\n"
164878
+                            "\t'v' to enable VLAN IDs to names resolution");
164878
             return FALSE;
164878
         }
164878
         break;