Blame SOURCES/0001-Set-s_uwtmp_inserted-only-after-record-insertion-rem.patch

54ac5f
From 96698a525784ad91cb27b572dd5f871c183fdfa5 Mon Sep 17 00:00:00 2001
54ac5f
From: =?UTF-8?q?Ond=C5=99ej=20Lyson=C4=9Bk?= <olysonek@redhat.com>
54ac5f
Date: Sun, 28 Jul 2019 12:25:35 +0200
54ac5f
Subject: [PATCH 1/3] Set s_uwtmp_inserted only after record insertion/removal
54ac5f
54ac5f
pututxline() is the function that actually inserts the new record, so
54ac5f
setting 's_uwtmp_inserted' before calling pututxline() doesn't make
54ac5f
sense.
54ac5f
54ac5f
We'll need this change for other fixes.
54ac5f
---
54ac5f
 sysdeputil.c | 4 ++--
54ac5f
 1 file changed, 2 insertions(+), 2 deletions(-)
54ac5f
54ac5f
diff --git a/sysdeputil.c b/sysdeputil.c
54ac5f
index 4fe56c2..bd1e8c9 100644
54ac5f
--- a/sysdeputil.c
54ac5f
+++ b/sysdeputil.c
54ac5f
@@ -1224,7 +1224,6 @@ vsf_insert_uwtmp(const struct mystr* p_user_str,
54ac5f
                        sizeof(s_utent.ut_line));
54ac5f
     str_free(&line_str);
54ac5f
   }
54ac5f
-  s_uwtmp_inserted = 1;
54ac5f
   s_utent.ut_type = USER_PROCESS;
54ac5f
   s_utent.ut_pid = vsf_sysutil_getpid();
54ac5f
   vsf_sysutil_strcpy(s_utent.ut_user, str_getbuf(p_user_str),
54ac5f
@@ -1235,6 +1234,7 @@ vsf_insert_uwtmp(const struct mystr* p_user_str,
54ac5f
   setutxent();
54ac5f
   (void) pututxline(&s_utent);
54ac5f
   endutxent();
54ac5f
+  s_uwtmp_inserted = 1;
54ac5f
   updwtmpx(WTMPX_FILE, &s_utent);
54ac5f
 }
54ac5f
 
54ac5f
@@ -1245,7 +1245,6 @@ vsf_remove_uwtmp(void)
54ac5f
   {
54ac5f
     return;
54ac5f
   }
54ac5f
-  s_uwtmp_inserted = 0;
54ac5f
   s_utent.ut_type = DEAD_PROCESS;
54ac5f
   vsf_sysutil_memclr(s_utent.ut_user, sizeof(s_utent.ut_user));
54ac5f
   vsf_sysutil_memclr(s_utent.ut_host, sizeof(s_utent.ut_host));
54ac5f
@@ -1253,6 +1252,7 @@ vsf_remove_uwtmp(void)
54ac5f
   setutxent();
54ac5f
   (void) pututxline(&s_utent);
54ac5f
   endutxent();
54ac5f
+  s_uwtmp_inserted = 0;
54ac5f
   s_utent.ut_tv.tv_sec = vsf_sysutil_get_time_sec();
54ac5f
   updwtmpx(WTMPX_FILE, &s_utent);
54ac5f
 }
54ac5f
-- 
54ac5f
2.20.1
54ac5f