Blame SOURCES/0001-Improve-documentation-of-ascii_-options.patch

ac8676
From a423831f25396c54f92cdfc6f92a104ed77c2ee6 Mon Sep 17 00:00:00 2001
ac8676
From: =?UTF-8?q?Ond=C5=99ej=20Lyson=C4=9Bk?= <olysonek@redhat.com>
ac8676
Date: Fri, 24 Nov 2017 11:26:37 +0100
ac8676
Subject: [PATCH] Improve documentation of ascii_* options
ac8676
ac8676
Resolves: rhbz#1517227
ac8676
---
ac8676
 vsftpd.conf   |  3 ++-
ac8676
 vsftpd.conf.5 | 20 ++++++++++++++++++++
ac8676
 2 files changed, 22 insertions(+), 1 deletion(-)
ac8676
ac8676
diff --git a/vsftpd.conf b/vsftpd.conf
ac8676
index 39d1955..acbc1e9 100644
ac8676
--- a/vsftpd.conf
ac8676
+++ b/vsftpd.conf
ac8676
@@ -73,7 +73,8 @@ xferlog_std_format=YES
ac8676
 #
ac8676
 # By default the server will pretend to allow ASCII mode but in fact ignore
ac8676
 # the request. Turn on the below options to have the server actually do ASCII
ac8676
-# mangling on files when in ASCII mode.
ac8676
+# mangling on files when in ASCII mode. The vsftpd.conf(5) man page explains
ac8676
+# the behaviour when these options are disabled.
ac8676
 # Beware that on some FTP servers, ASCII support allows a denial of service
ac8676
 # attack (DoS) via the command "SIZE /big/file" in ASCII mode. vsftpd
ac8676
 # predicted this attack and has always been safe, reporting the size of the
ac8676
diff --git a/vsftpd.conf.5 b/vsftpd.conf.5
ac8676
index d1f0db5..b6ddf05 100644
ac8676
--- a/vsftpd.conf.5
ac8676
+++ b/vsftpd.conf.5
ac8676
@@ -113,11 +113,31 @@ Default: YES
ac8676
 .TP
ac8676
 .B ascii_download_enable
ac8676
 When enabled, ASCII mode data transfers will be honoured on downloads.
ac8676
+When disabled, the server will pretend to allow ASCII mode but in fact
ac8676
+ignore requests to activate it. So the client will think the ASCII mode
ac8676
+is active and therefore may still translate any
ac8676
+.BR <CRLF>
ac8676
+character sequences in the received file. See the following article for
ac8676
+a detailed explanation of the behaviour:
ac8676
+https://access.redhat.com/articles/3250241.
ac8676
+
ac8676
+Turn this option on to have the server actually do
ac8676
+ASCII mangling on files when in ASCII mode.
ac8676
 
ac8676
 Default: NO
ac8676
 .TP
ac8676
 .B ascii_upload_enable
ac8676
 When enabled, ASCII mode data transfers will be honoured on uploads.
ac8676
+When disabled, the server will pretend to allow ASCII mode but in fact
ac8676
+ignore requests to activate it. So the client will think the ASCII mode
ac8676
+is active and will translate native line terminators to the standard
ac8676
+.BR <CRLF>
ac8676
+line terminators for transmission, but the server will not do
ac8676
+any translation. See the following article for a detailed explanation
ac8676
+of the behaviour: https://access.redhat.com/articles/3250241.
ac8676
+
ac8676
+Turn this option on to have the server actually do
ac8676
+ASCII mangling on files when in ASCII mode.
ac8676
 
ac8676
 Default: NO
ac8676
 .TP
ac8676
-- 
ac8676
2.14.3
ac8676