From 4e76b4d1bdff282160d9fa923ac45dda485e4254 Mon Sep 17 00:00:00 2001 From: "Eduardo Lima (Etrunko)" Date: Fri, 16 Aug 2019 14:40:23 -0300 Subject: [PATCH virt-viewer] ovirt-foreign-menu: Only set domain_valid once In the case of having a valid storage domain without any ISO files, this variable can be reset to FALSE again in the next iteration of the loop, resulting in a misleading error message presented to the user. Signed-off-by: Eduardo Lima (Etrunko) --- src/ovirt-foreign-menu.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c index a7e72dc..9c9a4e7 100644 --- a/src/ovirt-foreign-menu.c +++ b/src/ovirt-foreign-menu.c @@ -672,6 +672,7 @@ static gboolean storage_domain_validate(OvirtForeignMenu *menu G_GNUC_UNUSED, } #endif + g_debug ("Storage domain '%s' is %s", name, ret ? "valid" : "not valid"); g_free(name); return ret; } @@ -700,10 +701,12 @@ static void storage_domains_fetched_cb(GObject *source_object, while (g_hash_table_iter_next(&iter, NULL, (gpointer *)&domain)) { OvirtCollection *file_collection; - domain_valid = storage_domain_validate(menu, domain); - if (!domain_valid) + if (!storage_domain_validate(menu, domain)) continue; + if (!domain_valid) + domain_valid = TRUE; + file_collection = ovirt_storage_domain_get_files(domain); if (file_collection != NULL) { if (menu->priv->files) { -- 2.21.0