|
 |
5bafe0 |
From 8f1b485ddf106aae94ccdf14c26ad11a19c471b4 Mon Sep 17 00:00:00 2001
|
|
|
5bafe0 |
From: "Eduardo Lima (Etrunko)" <etrunko@redhat.com>
|
|
|
5bafe0 |
Date: Fri, 20 Oct 2017 15:00:46 -0200
|
|
|
5bafe0 |
Subject: [PATCH] remote-viewer: Pass guri to remote_viewer_session_connected
|
|
|
5bafe0 |
|
|
|
5bafe0 |
When connecting to a VM via oVirt instance, the original uri can not be
|
|
|
5bafe0 |
retrieved using virt_viewer_session_get_uri(). Consequently, it was
|
|
|
5bafe0 |
never saved, even though the connection succeeds and the actual callback
|
|
|
5bafe0 |
for "session-connected" signal, which saves the URI, is invoked.
|
|
|
5bafe0 |
|
|
|
5bafe0 |
To solve this problem, we always pass a copy of the guri as user-data
|
|
|
5bafe0 |
parameter for the callback, and if the call to
|
|
|
5bafe0 |
virt_viewer_session_get_uri() returns NULL, the parameter is used
|
|
|
5bafe0 |
instead.
|
|
|
5bafe0 |
|
|
|
5bafe0 |
Resolves: https://bugzilla.redhat.com/1459792
|
|
|
5bafe0 |
|
|
|
5bafe0 |
Backport from upstream 6608c0dd60fbf3a762a21a4d039fefc75c040406
|
|
|
5bafe0 |
|
|
|
5bafe0 |
Signed-off-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
|
|
|
5bafe0 |
---
|
|
|
5bafe0 |
src/remote-viewer.c | 11 +++++++----
|
|
|
5bafe0 |
1 file changed, 7 insertions(+), 4 deletions(-)
|
|
|
5bafe0 |
|
|
|
5bafe0 |
diff --git a/src/remote-viewer.c b/src/remote-viewer.c
|
|
|
5bafe0 |
index 7834dac..429f38c 100644
|
|
|
5bafe0 |
--- a/src/remote-viewer.c
|
|
|
5bafe0 |
+++ b/src/remote-viewer.c
|
|
|
5bafe0 |
@@ -1064,8 +1064,7 @@ remote_viewer_recent_add(gchar *uri, const gchar *mime_type)
|
|
|
5bafe0 |
.mime_type = (char*)mime_type,
|
|
|
5bafe0 |
};
|
|
|
5bafe0 |
|
|
|
5bafe0 |
- if (uri == NULL)
|
|
|
5bafe0 |
- return;
|
|
|
5bafe0 |
+ g_return_if_fail(uri != NULL);
|
|
|
5bafe0 |
|
|
|
5bafe0 |
recent = gtk_recent_manager_get_default();
|
|
|
5bafe0 |
meta.display_name = uri;
|
|
|
5bafe0 |
@@ -1075,13 +1074,17 @@ remote_viewer_recent_add(gchar *uri, const gchar *mime_type)
|
|
|
5bafe0 |
|
|
|
5bafe0 |
static void
|
|
|
5bafe0 |
remote_viewer_session_connected(VirtViewerSession *session,
|
|
|
5bafe0 |
- VirtViewerApp *self G_GNUC_UNUSED)
|
|
|
5bafe0 |
+ gchar *guri)
|
|
|
5bafe0 |
{
|
|
|
5bafe0 |
gchar *uri = virt_viewer_session_get_uri(session);
|
|
|
5bafe0 |
const gchar *mime = virt_viewer_session_mime_type(session);
|
|
|
5bafe0 |
|
|
|
5bafe0 |
+ if (uri == NULL)
|
|
|
5bafe0 |
+ uri = g_strdup(guri);
|
|
|
5bafe0 |
+
|
|
|
5bafe0 |
remote_viewer_recent_add(uri, mime);
|
|
|
5bafe0 |
g_free(uri);
|
|
|
5bafe0 |
+ g_free(guri);
|
|
|
5bafe0 |
}
|
|
|
5bafe0 |
|
|
|
5bafe0 |
static gboolean
|
|
|
5bafe0 |
@@ -1169,7 +1172,7 @@ retry_dialog:
|
|
|
5bafe0 |
}
|
|
|
5bafe0 |
|
|
|
5bafe0 |
g_signal_connect(virt_viewer_app_get_session(app), "session-connected",
|
|
|
5bafe0 |
- G_CALLBACK(remote_viewer_session_connected), app);
|
|
|
5bafe0 |
+ G_CALLBACK(remote_viewer_session_connected), g_strdup(guri));
|
|
|
5bafe0 |
|
|
|
5bafe0 |
virt_viewer_session_set_file(virt_viewer_app_get_session(app), vvfile);
|
|
|
5bafe0 |
#ifdef HAVE_OVIRT
|
|
|
5bafe0 |
--
|
|
|
5bafe0 |
2.13.6
|
|
|
5bafe0 |
|