|
 |
140d58 |
From 1f89726e848c174d1be4b41edaf0bcdaab0077ef Mon Sep 17 00:00:00 2001
|
|
|
140d58 |
From: Pavel Grunt <pgrunt@redhat.com>
|
|
|
140d58 |
Date: Tue, 17 Jan 2017 18:42:51 +0100
|
|
|
140d58 |
Subject: [PATCH 15/26] Do not print password in the debug log
|
|
|
140d58 |
|
|
|
140d58 |
Do not show a length since it is sensitive info as well.
|
|
|
140d58 |
|
|
|
140d58 |
Resolves: rhbz#1410030
|
|
|
140d58 |
|
|
|
140d58 |
Acked-by: Christophe Fergeau <cfergeau@redhat.com>
|
|
|
140d58 |
---
|
|
|
140d58 |
src/virt-viewer.c | 11 ++++++++++-
|
|
|
140d58 |
1 file changed, 10 insertions(+), 1 deletion(-)
|
|
|
140d58 |
|
|
|
140d58 |
diff --git a/src/virt-viewer.c b/src/virt-viewer.c
|
|
|
140d58 |
index 1121146..1f99552 100644
|
|
|
140d58 |
--- a/src/virt-viewer.c
|
|
|
140d58 |
+++ b/src/virt-viewer.c
|
|
|
140d58 |
@@ -928,6 +928,11 @@ virt_viewer_auth_libvirt_credentials(virConnectCredentialPtr cred,
|
|
|
140d58 |
}
|
|
|
140d58 |
|
|
|
140d58 |
for (i = 0 ; i < ncred ; i++) {
|
|
|
140d58 |
+ const char *cred_type_to_str[] = {
|
|
|
140d58 |
+ [VIR_CRED_USERNAME] = "Identity to act as",
|
|
|
140d58 |
+ [VIR_CRED_AUTHNAME] = "Identify to authorize as",
|
|
|
140d58 |
+ [VIR_CRED_PASSPHRASE] = "Passphrase secret",
|
|
|
140d58 |
+ };
|
|
|
140d58 |
switch (cred[i].type) {
|
|
|
140d58 |
case VIR_CRED_AUTHNAME:
|
|
|
140d58 |
case VIR_CRED_USERNAME:
|
|
|
140d58 |
@@ -936,7 +941,11 @@ virt_viewer_auth_libvirt_credentials(virConnectCredentialPtr cred,
|
|
|
140d58 |
cred[i].resultlen = strlen(cred[i].result);
|
|
|
140d58 |
else
|
|
|
140d58 |
cred[i].resultlen = 0;
|
|
|
140d58 |
- g_debug("Got '%s' %d %d", cred[i].result, cred[i].resultlen, cred[i].type);
|
|
|
140d58 |
+ g_debug("Got %s '%s' %d",
|
|
|
140d58 |
+ cred_type_to_str[cred[i].type],
|
|
|
140d58 |
+ /* hide password */
|
|
|
140d58 |
+ (cred[i].type == VIR_CRED_PASSPHRASE) ? "*****" : cred[i].result,
|
|
|
140d58 |
+ cred[i].type);
|
|
|
140d58 |
break;
|
|
|
140d58 |
}
|
|
|
140d58 |
}
|
|
|
140d58 |
--
|
|
|
140d58 |
2.12.0
|
|
|
140d58 |
|